Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: add support for stakeholder SIGs for WGs #3069

Merged
merged 1 commit into from Jan 16, 2019

Conversation

@nikhita
Copy link
Member

nikhita commented Jan 6, 2019

Tries to move #2176 forward.

https://github.com/kubernetes/community/blob/master/committee-steering/governance/wg-governance.md#creation-process-description specifies that WGs should have stakeholder SIGs. This PR adds support for mentioning the stakeholder SIGs in sigs.yaml. make generate will then automatically update sig-list.md and the relevant WGs' README.mds.

/hold
Do we want to add some stakeholder SIGs in this PR and iterate later? Or do we want to mention all of them in this PR?
Note: if we don't mention any stakeholder SIGs right now, but want to add support for stakeholder SIGs in the generator, then I can modify the template for sig-list.md such that the "Stakeholder SIGs" column in not shown if none of the WGs have that specified.

/committee steering
/sig contributor-experience
/kind feature

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Jan 6, 2019

@parispittman

This comment has been minimized.

Copy link
Contributor

parispittman commented Jan 7, 2019

lgtm but will hold for a tech review from cblecker or spiffxp

thank you so much @nikhita 🙇‍♀️ !! awesome

@cblecker

This comment has been minimized.

Copy link
Member

cblecker commented Jan 7, 2019

I'm good with this, but would like @spiffxp's opinion on this vs #2731

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Jan 16, 2019

@nikhita can you rebase? at a glance this seems ok, I will ping steering today

@nikhita nikhita force-pushed the nikhita:wg-list-sig-stakeholder branch from 1ef2520 to 0905af3 Jan 16, 2019

@nikhita

This comment has been minimized.

Copy link
Member Author

nikhita commented Jan 16, 2019

@spiffxp Thanks, rebased.

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Jan 16, 2019

/approve
/lgtm
Steering is fine with this and felt like they don't need to be involved. The larger generator PR is already at needs-rebase so I'd rather proceed with this. We'll leave the column empty and solicit WG's to fill in (or can take a stab based on the awesome work done by @zjs)

@k8s-ci-robot

This comment has been minimized.

Copy link
Contributor

k8s-ci-robot commented Jan 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp

This comment has been minimized.

Copy link
Member

spiffxp commented Jan 16, 2019

/hold cancel
I wanna PR in SIG stakeholders for wg-k8s-infra :)

@k8s-ci-robot k8s-ci-robot merged commit eef80b5 into kubernetes:master Jan 16, 2019

3 checks passed

cla/linuxfoundation nikhita authorized
Details
pull-community-verify Job succeeded.
Details
tide In merge pool.
Details

@nikhita nikhita deleted the nikhita:wg-list-sig-stakeholder branch Jan 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.