Skip to content

generator: add support for stakeholder SIGs for WGs#3069

Merged
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
nikhita:wg-list-sig-stakeholder
Jan 16, 2019
Merged

generator: add support for stakeholder SIGs for WGs#3069
k8s-ci-robot merged 1 commit into
kubernetes:masterfrom
nikhita:wg-list-sig-stakeholder

Conversation

@nikhita
Copy link
Copy Markdown
Member

@nikhita nikhita commented Jan 6, 2019

Tries to move #2176 forward.

https://github.com/kubernetes/community/blob/master/committee-steering/governance/wg-governance.md#creation-process-description specifies that WGs should have stakeholder SIGs. This PR adds support for mentioning the stakeholder SIGs in sigs.yaml. make generate will then automatically update sig-list.md and the relevant WGs' README.mds.

/hold
Do we want to add some stakeholder SIGs in this PR and iterate later? Or do we want to mention all of them in this PR?
Note: if we don't mention any stakeholder SIGs right now, but want to add support for stakeholder SIGs in the generator, then I can modify the template for sig-list.md such that the "Stakeholder SIGs" column in not shown if none of the WGs have that specified.

/committee steering
/sig contributor-experience
/kind feature

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. committee/steering Denotes an issue or PR intended to be handled by the steering committee. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 6, 2019
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Jan 6, 2019

/cc @cblecker @spiffxp @parispittman

@nikhita nikhita mentioned this pull request Jan 6, 2019
Closed
@parispittman
Copy link
Copy Markdown
Contributor

parispittman commented Jan 7, 2019

lgtm but will hold for a tech review from cblecker or spiffxp

thank you so much @nikhita 🙇‍♀️ !! awesome

@cblecker
Copy link
Copy Markdown
Member

cblecker commented Jan 7, 2019

I'm good with this, but would like @spiffxp's opinion on this vs #2731

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 13, 2019
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Jan 16, 2019

@nikhita can you rebase? at a glance this seems ok, I will ping steering today

@nikhita nikhita force-pushed the wg-list-sig-stakeholder branch from 1ef2520 to 0905af3 Compare January 16, 2019 17:48
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 16, 2019
@nikhita
Copy link
Copy Markdown
Member Author

nikhita commented Jan 16, 2019

@spiffxp Thanks, rebased.

@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Jan 16, 2019

/approve
/lgtm
Steering is fine with this and felt like they don't need to be involved. The larger generator PR is already at needs-rebase so I'd rather proceed with this. We'll leave the column empty and solicit WG's to fill in (or can take a stab based on the awesome work done by @zjs)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2019
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 16, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 16, 2019
@spiffxp
Copy link
Copy Markdown
Contributor

spiffxp commented Jan 16, 2019

/hold cancel
I wanna PR in SIG stakeholders for wg-k8s-infra :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 16, 2019
@k8s-ci-robot k8s-ci-robot merged commit eef80b5 into kubernetes:master Jan 16, 2019
@nikhita nikhita deleted the wg-list-sig-stakeholder branch January 17, 2019 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cblecker cblecker Awaiting requested review from cblecker

@spiffxp spiffxp Awaiting requested review from spiffxp

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@spiffxp spiffxp

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. committee/steering Denotes an issue or PR intended to be handled by the steering committee. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nikhita @parispittman @cblecker @spiffxp @k8s-ci-robot