Updated links in the different sigs folder under contributors/devel #7303

vaibhav2107 · 2023-05-18T07:23:31Z

Which issue(s) this PR fixes:

Fixes #7302

vaibhav2107 · 2023-05-18T07:24:23Z

/kind documentation

vaibhav2107 · 2023-05-18T07:25:19Z

Hi @ahg-g @guineveresaenger
Could you please have a look

ahg-g · 2023-05-18T22:19:44Z

/lgtm

for the scheduler bits

vaibhav2107 · 2023-05-26T06:44:42Z

Thanks @ahg-g

palnabarun · 2023-06-22T14:49:08Z

contributors/devel/sig-cli/kubectl-conventions.md

 this is not a mandatory structure and not every command is implemented this way,
 but this is a nice convention so try to be compliant with it. As an example,
-have a look at how [kubectl logs](https://git.k8s.io/kubernetes/pkg/kubectl/cmd/logs/logs.go) is implemented.
+have a look at how [kubectl logs](https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/kubectl/pkg/cmd/logs/logs.go) is implemented.


Can you please pin this to a commit so that the link does not go stale again?

Thanks @palnabarun for the review and suggestion, could you please explain a little more that how can I do this

You can click on Copy Permalink on the top right menu on GitHub UI when you open a file in the browser.

Ohk got it, you are asking to use permalink,,,sorry didn't understand it at first.

Sure, I will update this

palnabarun · 2023-06-22T14:49:26Z

contributors/devel/sig-scheduling/scheduling_code_hierarchy_overview.md

 through informers. Or custom plugins may be provided instead of the default ones.
 Known consumers of the scheduling framework:
- [cluster-autoscaler](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/simulator/scheduler_based_predicates_checker.go#L48-L79)
+- [cluster-autoscaler](https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/simulator/predicatechecker/schedulerbased.go)


Can you please pin this to a commit so that the link does not go stale again?

k8s-ci-robot · 2023-08-04T07:31:36Z

New changes are detected. LGTM label has been removed.

k8s-ci-robot · 2023-08-04T07:31:48Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vaibhav2107
Once this PR has been reviewed and has the lgtm label, please assign thockin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

contributors/devel/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

vaibhav2107 · 2023-08-04T07:32:43Z

Hi @palnabarun Could you please have a look now

k8s-ci-robot · 2023-08-07T06:34:33Z

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-triage-robot · 2024-01-20T22:09:55Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-02-19T22:23:13Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

vaibhav2107 · 2024-02-23T09:57:22Z

/remove-lifecycle rotten

vaibhav2107 · 2024-02-23T09:57:38Z

I will rebase the PR

k8s-triage-robot · 2024-05-23T10:01:25Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2024-06-22T10:18:56Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2024-07-22T10:33:50Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2024-07-22T10:33:54Z

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Updated links in the different sigs folder under contributors/devel

1585182

k8s-ci-robot requested review from ahg-g and guineveresaenger May 18, 2023 07:23

k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label May 18, 2023

k8s-ci-robot assigned ahg-g May 18, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 18, 2023

palnabarun reviewed Jun 22, 2023

View reviewed changes

Updated the link to permalink in community docs

3a0e5e2

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2023

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 7, 2023

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 20, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 19, 2024

k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 23, 2024

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 23, 2024

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 22, 2024

k8s-ci-robot closed this Jul 22, 2024

Updated links in the different sigs folder under contributors/devel #7303

Updated links in the different sigs folder under contributors/devel #7303

Uh oh!

Conversation

vaibhav2107 commented May 18, 2023

Uh oh!

vaibhav2107 commented May 18, 2023

Uh oh!

vaibhav2107 commented May 18, 2023

Uh oh!

ahg-g commented May 18, 2023

Uh oh!

vaibhav2107 commented May 26, 2023

Uh oh!

palnabarun Jun 22, 2023

Choose a reason for hiding this comment

Uh oh!

vaibhav2107 Aug 2, 2023

Choose a reason for hiding this comment

Uh oh!

palnabarun Aug 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vaibhav2107 Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

vaibhav2107 Aug 4, 2023

Choose a reason for hiding this comment

Uh oh!

palnabarun Jun 22, 2023

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Aug 4, 2023

Uh oh!

k8s-ci-robot commented Aug 4, 2023

Uh oh!

vaibhav2107 commented Aug 4, 2023

Uh oh!

k8s-ci-robot commented Aug 7, 2023

Uh oh!

k8s-triage-robot commented Jan 20, 2024

Uh oh!

k8s-triage-robot commented Feb 19, 2024

Uh oh!

vaibhav2107 commented Feb 23, 2024

Uh oh!

vaibhav2107 commented Feb 23, 2024

Uh oh!

k8s-triage-robot commented May 23, 2024

Uh oh!

k8s-triage-robot commented Jun 22, 2024

Uh oh!

k8s-triage-robot commented Jul 22, 2024

Uh oh!

k8s-ci-robot commented Jul 22, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

palnabarun Aug 3, 2023 •

edited

Loading