Skip to content

Updated the KEP with a Test Plan section#1522

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
arjunrn:update-hpa-test-plan
Jan 31, 2020
Merged

Updated the KEP with a Test Plan section#1522
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
arjunrn:update-hpa-test-plan

Conversation

@arjunrn
Copy link
Contributor

@arjunrn arjunrn commented Jan 29, 2020

A Test Section to track this change for the 1.18 release.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 29, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @arjunrn. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 29, 2020
@k8s-ci-robot k8s-ci-robot added kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. labels Jan 29, 2020

### Test Plan

This feature will include the following unit tests to test the following scenarios:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could say here the feature does include these unit tests. And provide a permalink to the tests.

Signed-off-by: Arjun Naik <arjun.rn@gmail.com>
@arjunrn arjunrn force-pushed the update-hpa-test-plan branch from 22e6d25 to fb41188 Compare January 31, 2020 06:39
@josephburnett
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 31, 2020
@arjunrn
Copy link
Contributor Author

arjunrn commented Jan 31, 2020

/assign mwielgus

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: arjunrn, josephburnett, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 8e09adf into kubernetes:master Jan 31, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Jan 31, 2020
RomanBednar pushed a commit to RomanBednar/enhancements that referenced this pull request Jul 30, 2024
…re-stores-tech-preview

OTA-916: enhancements/update/configurable-clusterversion-signature-stores: Tech-preview first
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants