Skip to content

Conversation

@chrislovecnm
Copy link
Contributor

@chrislovecnm chrislovecnm commented Jun 22, 2017

I am working on getting some changes pushed to our container. Once that is done I can test with a stable container.

Fixes #10, #7

TODO

  • add new container to manifest
  • update docs with new container
  • some testing

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 22, 2017
@ahmetb
Copy link
Member

ahmetb commented Jun 22, 2017

@chrislovecnm I am not sure we're good with deleting the example altogether. I have an active plan to move the README.md of this example to the Kubernetes.io website (#12 and kubernetes/website#4134) and applying this patch would remove this tutorial temporarily, and conflict with the work I am doing.

Instead of removing this example first, I would much rather prefer you just patch it in-place.

@chrislovecnm
Copy link
Contributor Author

So I am not removing the example, just portions of the example that are no longer functioning, and are not recommended. The DS example is broken, and with StatefulSets I would never recommend running a DS. Cassandra does not like when mulitple instances start at the same time.

I am happy to leave this open until you merge, but really we should update this example before it is on our website.

@ahmetb
Copy link
Member

ahmetb commented Jun 22, 2017

My bad, the rendering tricked me. I'll review.

@ahmetb ahmetb changed the title [WIP] Clean-up removing old examples [WIP] cassandra: Clean-up removing old examples Jun 26, 2017
[2]: https://kubernetes.io/docs/concepts/services-networking/service/
[3]: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/
[Cassandra]: [http://cassandra.apache.org/]
[container registry]: [https://quay.io/repository/vorstella/cassandra-k8s]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can help you update the gcr.io/google-samples/cassandra image if necessary, if you check in the Dockerfile.

Currently with this patch, we won't have the Dockerfile and you'll be the only one who has write access to the image.

@ahmetb
Copy link
Member

ahmetb commented Jun 27, 2017

@chrislovecnm I just sent #16 moving the tutorial (README.md) to the kubernetes/kubernetes.github.io repository repository. (kubernetes/website#4179)

I saw that you have some non-trivial changes in README.md, we probably need to apply those to the kubernetes/kubernetes.github.io repository now.

@ahmetb
Copy link
Member

ahmetb commented Jul 15, 2017

@chrislovecnm sorry for the unnecessary back and forth here. We decided to keep the cassandra/README.md in this repo, but I made some minor changes, so it renders on the website correctly at its new home: https://kubernetes.io/docs/tutorials/stateful-application/cassandra/

Do you mind resolving the merge conflicts when you have time?

@chrislovecnm
Copy link
Contributor Author

Yah no worries. I think I have a base container that is happy now.

Are we leaving the container in gcr.io or can I use one that I maintain?

@ahmetb
Copy link
Member

ahmetb commented Jul 16, 2017

Let's leave it on gcr.io. I can easily update it if you have a new Dockerfile.

@ahmetb
Copy link
Member

ahmetb commented Jul 16, 2017

Let's update references to gcr.io/google-samples/cassandra:v13 and I'll make it available if you can check in the Dockerfile back.

@ahmetb
Copy link
Member

ahmetb commented Jul 27, 2017

#38 made some improvements to Cassandra tutorial, it would be great if we can apply the changes suggested above to that.

@krjw
Copy link

krjw commented Aug 17, 2017

I figured that the current example is meant to work with 3.10, which is not available anymore... bump it to 3.11.0 in the make file? Otherwise building the image fails!

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 3, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten
/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 8, 2018
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants