-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[WIP] cassandra: Clean-up removing old examples #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@chrislovecnm I am not sure we're good with deleting the example altogether. I have an active plan to move the README.md of this example to the Kubernetes.io website (#12 and kubernetes/website#4134) and applying this patch would remove this tutorial temporarily, and conflict with the work I am doing. Instead of removing this example first, I would much rather prefer you just patch it in-place. |
|
So I am not removing the example, just portions of the example that are no longer functioning, and are not recommended. The DS example is broken, and with StatefulSets I would never recommend running a DS. Cassandra does not like when mulitple instances start at the same time. I am happy to leave this open until you merge, but really we should update this example before it is on our website. |
|
My bad, the rendering tricked me. I'll review. |
| [2]: https://kubernetes.io/docs/concepts/services-networking/service/ | ||
| [3]: https://kubernetes.io/docs/concepts/workloads/controllers/statefulset/ | ||
| [Cassandra]: [http://cassandra.apache.org/] | ||
| [container registry]: [https://quay.io/repository/vorstella/cassandra-k8s] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can help you update the gcr.io/google-samples/cassandra image if necessary, if you check in the Dockerfile.
Currently with this patch, we won't have the Dockerfile and you'll be the only one who has write access to the image.
|
@chrislovecnm I just sent #16 moving the tutorial (README.md) to the I saw that you have some non-trivial changes in README.md, we probably need to apply those to the |
|
@chrislovecnm sorry for the unnecessary back and forth here. We decided to keep the Do you mind resolving the merge conflicts when you have time? |
|
Yah no worries. I think I have a base container that is happy now. Are we leaving the container in gcr.io or can I use one that I maintain? |
|
Let's leave it on gcr.io. I can easily update it if you have a new Dockerfile. |
|
Let's update references to |
|
#38 made some improvements to Cassandra tutorial, it would be great if we can apply the changes suggested above to that. |
|
I figured that the current example is meant to work with 3.10, which is not available anymore... bump it to 3.11.0 in the make file? Otherwise building the image fails! |
|
Issues go stale after 90d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
|
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
|
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
I am working on getting some changes pushed to our container. Once that is done I can test with a stable container.
Fixes #10, #7
TODO