Skip to content

Add option to read password from file#431

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
zhouhaibing089:flag-password-file
Jul 5, 2021
Merged

Add option to read password from file#431
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
zhouhaibing089:flag-password-file

Conversation

@zhouhaibing089
Copy link
Copy Markdown

@zhouhaibing089 zhouhaibing089 commented Jun 29, 2021 •
edited by thockin
Loading

A new flag --password-file is added. This allows git-sync to read
password from file and this is considered as safer than reading from
env or flag directly.

Few more checks are added as well:

  1. --password and --password-file can't be specified at the same
    time.
  2. If --username is specified, then one of --password or
    --password-file must be specified.

Fixes #429

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 29, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jun 29, 2021

Welcome @zhouhaibing089!

It looks like this is your first PR to kubernetes/git-sync 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/git-sync has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot requested review from nan-yu and thockin June 29, 2021 20:25
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 29, 2021
@zhouhaibing089 zhouhaibing089 mentioned this pull request Jun 29, 2021
Closed
@thockin thockin self-assigned this Jun 29, 2021
thockin
thockin reviewed Jul 5, 2021
View reviewed changes
Comment thread cmd/git-sync/main.go Outdated
Comment thread README.md Outdated
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 5, 2021
thockin
thockin reviewed Jul 5, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really small not, then LGTM. Thanks.

Comment thread README.md Outdated
Add option to read password from file
6076daf 
A new flag `--password-file` is added. This allows git-sync to read
password from file and this is considered as safer than reading from
env or flag directly.

Few more checks are added as well:

1. `--password` and `--password-file` can't be specified at the same
time.
1. If `--username` is specified, then one of `--password` or
`--password-file` must be specified.
thockin
thockin reviewed Jul 5, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2021
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jul 5, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, zhouhaibing089

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021
@thockin
Copy link
Copy Markdown
Member

thockin commented Jul 5, 2021

I will port to the dev branch

@k8s-ci-robot k8s-ci-robot merged commit 83d9a44 into kubernetes:master Jul 5, 2021
thockin added a commit to thockin/git-sync that referenced this pull request Jul 5, 2021
@thockin
Add option to read passwd from file
2a81ea6 
This is a port of kubernetes#431.

A new flag `--password-file` is added. This allows git-sync to read
password from file and this is considered as safer than reading from
env or flag directly.

Few more checks are added as well:

1. `--password` and `--password-file` can't be specified at the same
time.
2. If `--username` is specified, then one of `--password` or
`--password-file` must be specified.
@thockin thockin mentioned this pull request Jul 5, 2021
Merged
@zhouhaibing089 zhouhaibing089 deleted the flag-password-file branch July 6, 2021 01:38
k8s-ci-robot added a commit that referenced this pull request Jul 6, 2021
@k8s-ci-robot
Merge pull request #436 from thockin/master
766682c 
Small nits I found with password-file while porting #431
eminugurkenar pushed a commit to eminugurkenar/git-sync that referenced this pull request Aug 16, 2021
@thockin @eminugurkenar
Add option to read passwd from file
d28d580 
This is a port of kubernetes#431.

A new flag `--password-file` is added. This allows git-sync to read
password from file and this is considered as safer than reading from
env or flag directly.

Few more checks are added as well:

1. `--password` and `--password-file` can't be specified at the same
time.
2. If `--username` is specified, then one of `--password` or
`--password-file` must be specified.
@p-linnane p-linnane mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thockin thockin thockin left review comments

@nan-yu nan-yu Awaiting requested review from nan-yu

Assignees

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhouhaibing089 @k8s-ci-robot @thockin