add manifests for initial deployment of sippy #1615

deads2k · 2021-02-05T19:05:17Z

builds on #1614

This adds manifests to deploy and run sippy. This is similar to what I have in my private toy cluster, but I need to do a little bit of alignment and work out ingresses instead of routes.

/assign @wojtek-t

/hold

explicit hold until I'm able to test these locally.

wojtek-t · 2021-02-08T10:46:56Z

groups/groups.yaml

      - k8s-infra-rbac-triageparty-release@kubernetes.io
      - k8s-infra-rbac-slack-infra@kubernetes.io
      - k8s-infra-rbac-node-perf-dash@kubernetes.io
+      - k8s-infra-rbac-wg-reliability@kubernetes.io


nit: This is already merged - please rebase

wojtek-t · 2021-02-08T10:48:58Z

wg-reliability/README.md

+wg-reliability has tools used to aid in transparency of stability metrics.
+
+[sippy](https://github.com/openshift/sippy) summarizes multiple test-grid dashboards with data slicing of related jobs, job runs,
+and tests.  Visit (placeholder for eventual URL) to see the kube instance. 


We should probably request public IP and DNS now (given we already have support for running it).

I'm wondering if we want "sippy.k8s.io" or something more generic?

wojtek-t · 2021-02-08T10:50:18Z

wg-reliability/sippy/service.yaml

@@ -0,0 +1,17 @@
+apiVersion: v1
+kind: Service


We also want Ingress and Certificate too, as e.g. here:
https://github.com/kubernetes/k8s.io/tree/master/perf-dash.k8s.io

wojtek-t · 2021-02-08T10:51:36Z

wg-reliability/sippy/deployment.yaml

+            - --local-data
+            - /data
+            - --dashboard
+            - kube-master=sig-release-master-blocking,sig-release-master-informing=


Do we want both? Or maybe we want to start just with blocking?

Or actually, I guess it's probably moot anyway, because we probably want to create our own dashboard for this purpose...

wojtek-t · 2021-02-08T10:54:52Z

wg-reliability/sippy/deployment.yaml

+          terminationMessagePath: /dev/termination-log
+          terminationMessagePolicy: File
+          command:
+            - /tmp/src/scripts/fetchdata-kube.sh


What is this? I didn't see that anywhere.
I think you can simply run:
./sippy --fetch-data /usr/local/google/home/wojtekt/sippy_data --dashboard=kube-master=sig-release-master-blocking=

Or I guess, you might wanted this to run periodically already.
Do we want a container? Or do we want a CronJob that will be doing this?

Ahh - I guess with CronJob, we may have a problem with mounting for different pods...

So we probably want this to be a container within a pod.

wojtek-t · 2021-02-08T10:55:05Z

wg-reliability/sippy/deployment.yaml

+            - mountPath: /data
+              name: data
+      restartPolicy: Always
+      terminationGracePeriodSeconds: 30


Isn't 30 default?

wojtek-t · 2021-02-08T10:56:41Z

wg-reliability/sippy/pvc.yaml

+    - ReadWriteOnce
+  resources:
+    requests:
+      storage: 900M


I guess we want to set some StorageClass, right?

spiffxp · 2021-02-25T17:32:17Z

/retest

spiffxp

I would rather see these manifests in a folder called sippy or sippy.k8s.io, in a sippy namespace to match.

If we're going down the path of assigning group ownership to apps deployed in cluster (we should! accountability is great!) I would rather see a sig: foo label, given that wg's don't own code.

I would suggest sig: architecture or sig: release to start... though long term it should be sig: testing when we have bandwidth.

spiffxp · 2021-02-25T17:43:43Z

/hold

wojtek-t

This looks fine to me (modulo missing storage class).

wojtek-t · 2021-03-23T14:50:23Z

sippy/sippy/pvc.yaml

+  resources:
+    requests:
+      storage: 900M
+  # storageClassName: standard


@spiffxp - what storage class we have in the community cluster?

@wojtek-t we have 2 storage classes in the cluster :

kubectl get sc NAME PROVISIONER AGE ssd kubernetes.io/gce-pd 334d standard (default) kubernetes.io/gce-pd 551d

Thanks!

@deads2k - standard should be good enough for us;
Though I would visibly increase the size, say to 10GB or sth.

@deads2k - friendly ping

spiffxp

/approve
/lgtm
/hold
Remove /hold when ready to deploy

Thanks for changing the namespace, I ended up setting it up via #1844 so you'll likely need to rebase

spiffxp · 2021-03-30T20:11:07Z

groups/groups.yaml


-  - email-id: k8s-infra-rbac-wg-reliability@kubernetes.io
-    name: k8s-infra-rbac-wg-reliability
+  - email-id: k8s-infra-rbac-sippy@kubernetes.io


You'll probably need to rebase, I did this in #1844

spiffxp

/lgtm

spiffxp · 2021-03-31T23:52:17Z

sippy/sippy/ingress.yaml

@@ -0,0 +1,17 @@
+apiVersion: networking.k8s.io/v1


I'm not sure if aaa is at a version that supports this

good catch - the cluster is still in 1.16 (will be upgraded to 1.17 soon, but ingress/v1 is only in 1.19), so we should use v1beta1 stil...

k8s-ci-robot · 2021-03-31T23:53:06Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [spiffxp]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wojtek-t · 2021-04-01T18:30:29Z

/lgtm

deads2k · 2021-04-01T19:10:13Z

/hold

We will merge on monday when everyone is back in the office and ready for potential excitement

deads2k · 2021-04-08T16:36:14Z

/hold cancel

here we go!

sbueringer · 2021-04-08T17:58:51Z

@deads2k for even more excitement. Is there a specific issue where I can follow the implementation?

deads2k · 2021-04-08T18:56:41Z

@deads2k for even more excitement. Is there a specific issue where I can follow the implementation?

sippy lives here: https://github.com/openshift/sippy/

sbueringer · 2021-04-08T19:02:40Z

Ah sorry that was misleading. I meant more like the deployment of sippy for the kubernetes repos. I saw the DNS name sippy.k8s.io, but it's not available yet. So I assumed there might be an issue somewhere (which I can subscribe to) to stay up-to-date about the deployment implementation.

deads2k · 2021-04-08T19:10:55Z

Ah sorry that was misleading. I meant more like the deployment of sippy for the kubernetes repos. I saw the DNS name sippy.k8s.io, but it's not available yet. So I assumed there might be an issue somewhere (which I can subscribe to) to stay up-to-date about the deployment implementation.

As it happens, I was just starting to look now and I haven't worked out where my resources went.

deads@cloudshell:~$ kubectl --context=prod-aaa -nsippy get pod
No resources found in sippy namespace.
deads@cloudshell:~$ kubectl --context=prod-aaa -nsippy get deployment
No resources found in sippy namespace.
deads@cloudshell:~$ kubectl --context=prod-aaa -nsippy get all
Error from server (Forbidden): replicationcontrollers is forbidden: User "deads@redhat.com" cannot list resource "replicationcontrollers" in API group "" in the namespace "sippy": r
equires one of ["container.replicationControllers.list"] permission(s).
Error from server (Forbidden): daemonsets.apps is forbidden: User "deads@redhat.com" cannot list resource "daemonsets" in API group "apps" in the namespace "sippy": requires one of 
["container.daemonSets.list"] permission(s).
deads@cloudshell:~$ kubectl --context=prod-aaa -nsippy get ingress
No resources found in sippy namespace.

sbueringer · 2021-04-08T19:12:59Z

Ah got it, thx :). I'll just follow the update here then.

ameukam · 2021-04-08T19:30:25Z

@deads2k 👋🏾 , resources deployment is still a manual action in aaa. You will need to connect and deploy them yourself.

spiffxp · 2021-04-09T14:58:27Z

Part of #1900

k8s-ci-robot assigned wojtek-t Feb 5, 2021

k8s-ci-robot requested review from dims and thockin February 5, 2021 19:05

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 5, 2021

wojtek-t reviewed Feb 8, 2021

View reviewed changes

Base automatically changed from master to main February 9, 2021 00:35

deads2k force-pushed the manifests branch from feb8da7 to b9f68c5 Compare February 22, 2021 16:19

deads2k changed the title ~~[wip] add manifests for initial deployment of sippy~~ add manifests for initial deployment of sippy Feb 22, 2021

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 22, 2021

spiffxp suggested changes Feb 25, 2021

View reviewed changes

k8s-ci-robot assigned spiffxp Feb 25, 2021

deads2k force-pushed the manifests branch from b9f68c5 to 4b8547e Compare March 23, 2021 14:40

wojtek-t reviewed Mar 23, 2021

View reviewed changes

spiffxp approved these changes Mar 30, 2021

View reviewed changes

k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 30, 2021

deads2k force-pushed the manifests branch from 4b8547e to 727a4eb Compare March 31, 2021 23:23

k8s-ci-robot removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 31, 2021

spiffxp approved these changes Mar 31, 2021

View reviewed changes

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 31, 2021

deads2k force-pushed the manifests branch from 727a4eb to 4c7142c Compare April 1, 2021 17:36

k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2021

add starting manifests for wg-reliability-sippy

6799c93

deads2k force-pushed the manifests branch from 4c7142c to 6799c93 Compare April 1, 2021 18:27

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 1, 2021

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 8, 2021

k8s-ci-robot merged commit ee7f23e into kubernetes:main Apr 8, 2021

k8s-ci-robot added this to the v1.21 milestone Apr 8, 2021

deads2k mentioned this pull request Apr 8, 2021

cannot find sippy deployment #1889

Closed

spiffxp mentioned this pull request Apr 9, 2021

Get sippy.k8s.io up and running #1900

Closed

add manifests for initial deployment of sippy #1615

add manifests for initial deployment of sippy #1615

Uh oh!

Conversation

deads2k commented Feb 5, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spiffxp commented Feb 25, 2021

Uh oh!

spiffxp left a comment

Choose a reason for hiding this comment

Uh oh!

spiffxp commented Feb 25, 2021

Uh oh!

wojtek-t left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spiffxp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

spiffxp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

k8s-ci-robot commented Mar 31, 2021

Uh oh!

wojtek-t commented Apr 1, 2021

Uh oh!

deads2k commented Apr 1, 2021

Uh oh!

deads2k commented Apr 8, 2021

Uh oh!

sbueringer commented Apr 8, 2021

Uh oh!

deads2k commented Apr 8, 2021

Uh oh!

sbueringer commented Apr 8, 2021

Uh oh!

deads2k commented Apr 8, 2021

Uh oh!

sbueringer commented Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ameukam commented Apr 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spiffxp commented Apr 9, 2021

Uh oh!

Reviewers

Assignees

sbueringer commented Apr 8, 2021 •

edited

Loading

ameukam commented Apr 8, 2021 •

edited

Loading