Skip to content

Conversation

@spiffxp
Copy link
Contributor

@spiffxp spiffxp commented Mar 30, 2021

I think there's a mismatch between group name and ns for rbac.

I had commented earlier that the convention to follow is naming the namespace/group after the app in question, instead of the community group responsible for it.

Let's start down that path (and add my non-privileged account to the existing group for troubleshooting)

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 30, 2021
@k8s-ci-robot k8s-ci-robot requested review from dims and thockin March 30, 2021 17:43
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. wg/k8s-infra labels Mar 30, 2021
Update rbac group descriptions while I'm here
@spiffxp spiffxp force-pushed the troubleshoot-sippy branch from c135890 to 9fde204 Compare March 30, 2021 17:45
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 30, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hasheddan, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 350047e into kubernetes:main Mar 30, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Mar 30, 2021
@spiffxp spiffxp deleted the troubleshoot-sippy branch March 30, 2021 17:58
@spiffxp
Copy link
Contributor Author

spiffxp commented Mar 30, 2021

Applied namespace changes

spiffxp@cloudshell:~/k8s.io/infra/gcp/namespaces (kubernetes-public)$ ./ensure-namespaces.sh gke_kubernetes-public_us-central1_aaa

@spiffxp
Copy link
Contributor Author

spiffxp commented Mar 30, 2021

Yeah, mismatch between group name and namespace is the problem. This group doesn't exist.

$ k describe rolebindings -n wg-reliability-sippy namespace-user
Name:         namespace-user
Labels:       <none>
Annotations:  <none>
Role:
  Kind:  Role
  Name:  namespace-user
Subjects:
  Kind   Name                                               Namespace
  ----   ----                                               ---------
  Group  k8s-infra-rbac-wg-reliability-sippy@kubernetes.io

I would prefer to correct and rectify with the sippy NS I just created

@spiffxp
Copy link
Contributor Author

spiffxp commented Apr 9, 2021

Part of #1900

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/access Define who has access to what via IAM bindings, role bindings, policy, etc. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants