Skip to content

Add release-0.3 and tip for cluster-api #2269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 7, 2021
Merged

Add release-0.3 and tip for cluster-api #2269

merged 1 commit into from
Jul 7, 2021

Conversation

@vincepri
Copy link
Member

@vincepri vincepri commented Jun 24, 2021

Signed-off-by: Vince Prignano vincepri@vmware.com

@vincepri
Add release-0.3 and tip for cluster-api
a3e07aa 
Signed-off-by: Vince Prignano <vincepri@vmware.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 24, 2021
@k8s-ci-robot k8s-ci-robot added area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 24, 2021
CecileRobertMichon
CecileRobertMichon reviewed Jun 24, 2021
View reviewed changes
Copy link
Member

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 24, 2021
@dims
Copy link
Member

dims commented Jun 24, 2021

@thockin is just merging this enough or do i still need to run some stuff by hand? (if i remember right you were making changes there, is it already done?)

/assign @thockin

@CecileRobertMichon CecileRobertMichon mentioned this pull request Jun 28, 2021
Merged
@CecileRobertMichon
Copy link
Member

CecileRobertMichon commented Jul 6, 2021

ping @thockin

@CecileRobertMichon CecileRobertMichon mentioned this pull request Jul 7, 2021
Closed
thockin
thockin reviewed Jul 7, 2021
View reviewed changes
Copy link
Member

@thockin thockin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jul 7, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thockin, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1c547ed into kubernetes:main Jul 7, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 7, 2021
@sedefsavas sedefsavas mentioned this pull request Nov 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bartsmykla bartsmykla Awaiting requested review from bartsmykla

2 more reviewers

@thockin thockin thockin left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@thockin thockin

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dns DNS records for k8s.io, kubernetes.io, k8s.dev, etc., code in dns/ cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

v1.22

Development

Successfully merging this pull request may close these issues.

5 participants

@vincepri @dims @CecileRobertMichon @k8s-ci-robot @thockin