Skip to content

Conversation

@a-mccarthy
Copy link
Contributor

@a-mccarthy a-mccarthy commented Dec 5, 2016

adding a page and navigation link for the new issue review process to handle the backlog


This change is Reviewable

a-mccarthy added 3 commits November 29, 2016 12:21
adds a new page to the contribute section and navigation that describes
the reviewing and labeling process for backlog/newly created issues
@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

Once you've signed, please reply here (e.g. "I signed it!") and we'll verify. Thanks.


If you have questions or suggestions related to this bot's behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Dec 5, 2016


#### Tech Review Needed
* Issues that need more information in order to be worked on (the proposed solution needs to be proven, a SME needs to be involved, work needs to be done to understand the problem/resolution and if the issue is still relevant)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean SWE, or is SME something different?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i meant subject matter expert




{% capture whatsnext %}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If using the whatsnext section, all your other headings need to be at least H3 (###) or else the TOC gets confused. See the preview for example: https://deploy-preview-1860--kubernetes-io-vnext-staging.netlify.com/docs/contribute/review-issues/

@a-mccarthy
Copy link
Contributor Author

I signed it!

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Dec 12, 2016

{% capture overview %}

This page explains how you should review and prioritize documentation issues made for the [kubernetes/kubernetes.github.io](https://github.com/kubernetes/kubernetes.github.io){: target="_blank"} repository. The purpose is to provide a way to organize issues and make it easier to contribute to Kubernetes documentation. The following should be used as the standard way of prioritizing, labeling, and interacting with issues.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this render correctly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think so, i looks correct on netlify. is there something specific you were worried about, or the whole page?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think GH's raw markdown processor was a little wonky and italicized about half the document. If it looks fine in Netlify, LGTM.

@devin-donnelly
Copy link
Contributor

@a-mccarthy We need to fix the merge conflict in the support TOC.

@devin-donnelly devin-donnelly added needs-rebase and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 21, 2016
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 4, 2017
@devin-donnelly devin-donnelly merged commit e2e2582 into kubernetes:master Jan 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants