-
Notifications
You must be signed in to change notification settings - Fork 41.8k
kubelet: fix kubeletconfig.cgroupDriver in configz #134743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubelet: fix kubeletconfig.cgroupDriver in configz #134743
Conversation
Reflect the correct cgroupDriver setting in the configz enpoint in case the cgroup driver setting is received from the CRI. Moves the initialization of the configz handler to a slightly later phase where the CRI has been queried.
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cc @SergeyKanzhelev |
SergeyKanzhelev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
|
LGTM label has been added. Git tree hash: 5e44e59d0d8a488d2faab206bc835cdd871d7c9e
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: marquiz, SergeyKanzhelev The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reflect the correct cgroupDriver setting in the configz enpoint in case the cgroup driver setting is received from the CRI. Moves the initialization of the configz handler to a slightly later phase where the CRI has been queried.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Which issue(s) this PR is related to:
Fixes #134673
Special notes for your reviewer:
Related to kubernetes/enhancements#4033
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: