Revert- Don't pick versions that have a replacement as storage

[Jefftree]

What type of PR is this?

/kind bug

What this PR does / why we need it:

This reverts #128454

see #134556 (comment) for details

I don't think this is actively being used. The original candidate for v1alpha3 has been removed: https://github.com/kubernetes/kubernetes/blob/master/staging/src/k8s.io/api/resource/v1alpha3/types.go

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixes the replacement tag in APIs to not be a selector for storage version

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

/cc @jpbetz @liggitt

[k8s-ci-robot]

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Jefftree]

/cc @jpbetz @liggitt

[liggitt]

lgtm, is there a test that would notice if removal of this changed calculated storage versions for any current APIs / emulation versions?

[Jefftree]

lgtm, is there a test that would notice if removal of this changed calculated storage versions for any current APIs / emulation versions?

the etcd storage path tests, especially the emulated n-1...n-3 tests should test that code path

[liggitt]

/lgtm
/approve
/hold for @jpbetz ack

[k8s-ci-robot]

LGTM label has been added.

Details

Git tree hash: 9f1e4b7001c1bc3c7cd0e53b4e3f2984599df0eb

[jpbetz]

/approve
/hold cancel

The linked comment thread was helpful context.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jefftree, jpbetz, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• staging/src/k8s.io/apiserver/OWNERS [jpbetz,liggitt]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment