Skip to content

Small refactoring around drain - move drain logic to separate function. #24923

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2016
Merged

Small refactoring around drain - move drain logic to separate function. #24923

merged 1 commit into from
May 11, 2016

Conversation

@mwielgus
Copy link
Contributor

@mwielgus mwielgus commented Apr 28, 2016

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Apr 28, 2016
@wojtek-t wojtek-t assigned janetkuo and unassigned wojtek-t Apr 28, 2016
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 29, 2016
@mwielgus mwielgus mentioned this pull request Apr 29, 2016
Merged
@eparis eparis mentioned this pull request Apr 29, 2016
Closed
@eparis eparis removed the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Apr 29, 2016
@mwielgus mwielgus mentioned this pull request May 2, 2016
Merged
janetkuo
janetkuo reviewed May 3, 2016
View reviewed changes
pkg/kubectl/cmd/drain.go Outdated
Copy link
Member

@janetkuo janetkuo May 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest making this private

Copy link
Member

@janetkuo janetkuo May 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removeUnderplicated: did you mean removeUnreplicated (typo)?

Copy link
Member

@janetkuo janetkuo May 3, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not name it force?

Copy link
Contributor Author

@mwielgus mwielgus May 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole purpose of this refactoring is to make it public :).

Other comments applied.

@janetkuo janetkuo added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels May 3, 2016
@janetkuo janetkuo added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 5, 2016
@janetkuo
Copy link
Member

janetkuo commented May 5, 2016

LGTM now. Thanks!

@bgrant0607 bgrant0607 assigned janetkuo and unassigned bgrant0607 May 7, 2016
@bgrant0607
Copy link
Member

bgrant0607 commented May 7, 2016

cc @mml

@piosz piosz added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 10, 2016
@piosz
Copy link
Member

piosz commented May 10, 2016

Bumped priority, cluster autoscaler in a blocker for 1.3

@piosz piosz added this to the v1.3 milestone May 10, 2016
@k8s-bot
Copy link

k8s-bot commented May 10, 2016

GCE e2e build/test passed for commit 60f1339.

@k8s-github-robot
Copy link

k8s-github-robot commented May 11, 2016

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

@k8s-bot
Copy link

k8s-bot commented May 11, 2016

GCE e2e build/test passed for commit 60f1339.

@k8s-github-robot
Copy link

k8s-github-robot commented May 11, 2016

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit c10d12b into kubernetes:master May 11, 2016
@foxish foxish mentioned this pull request Jan 21, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@janetkuo janetkuo

Labels

lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

v1.3

Development

Successfully merging this pull request may close these issues.

9 participants

@mwielgus @janetkuo @bgrant0607 @piosz @k8s-bot @k8s-github-robot @googlebot @eparis @wojtek-t