custom-plugin-monitor: Really skip initial statuses#1269
custom-plugin-monitor: Really skip initial statuses#1269halaney wants to merge 1 commit intokubernetes:masterfrom
Conversation
Right now with SkipInitialStatus we skip the initial status update,
but it doesn't really achieve the goal of skipping sending initial
status values for conditions overall. For example, right now:
1. We set conditions to their default values internally
2. We run our checks
3. The first check returns a Result
4. This Result is used to updated the conditions slice we hold
internally
5. We send out all the conditions
meaning we are sending the default value out still for most of the
conditions.
Instead in this skip initial status config we should only add conditions
that have actually reported a result.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: halaney The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @halaney. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Right now with SkipInitialStatus we skip the initial status update, but it doesn't really achieve the goal of skipping sending initial status values for conditions overall. For example, right now:
meaning we are sending the default value out still for most of the conditions.
Instead in this skip initial status config we should only add conditions that have actually reported a result.