Skip to content

custom-plugin-monitor: Really skip initial statuses#1269

Open
halaney wants to merge 1 commit intokubernetes:masterfrom
halaney:really-skip-initial-status
Open

custom-plugin-monitor: Really skip initial statuses#1269
halaney wants to merge 1 commit intokubernetes:masterfrom
halaney:really-skip-initial-status

Conversation

@halaney
Copy link
Copy Markdown

@halaney halaney commented Apr 22, 2026

Right now with SkipInitialStatus we skip the initial status update, but it doesn't really achieve the goal of skipping sending initial status values for conditions overall. For example, right now:

1. We set conditions to their default values internally
2. We run our checks
3. The first check returns a Result
4. This Result is used to updated the conditions slice we hold internally
5. We send out all the conditions

meaning we are sending the default value out still for most of the conditions.

Instead in this skip initial status config we should only add conditions that have actually reported a result.

Right now with SkipInitialStatus we skip the initial status update,
but it doesn't really achieve the goal of skipping sending initial
status values for conditions overall. For example, right now:

    1. We set conditions to their default values internally
    2. We run our checks
    3. The first check returns a Result
    4. This Result is used to updated the conditions slice we hold
       internally
    5. We send out all the conditions

meaning we are sending the default value out still for most of the
conditions.

Instead in this skip initial status config we should only add conditions
that have actually reported a result.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: halaney
Once this PR has been reviewed and has the lgtm label, please assign mrunalp for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

Hi @halaney. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants