Add option to dns performance test to install additional YAMLs

[rahulkjoshi]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Provides the capability to apply additional manifests before starting a DNS performance test. This can be used to install other features that might need to be scaled tested (e.g. egress gateways, network policies, etc.)

[k8s-ci-robot]

Welcome @rahulkjoshi!

It looks like this is your first PR to kubernetes/perf-tests 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/perf-tests has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rahulkjoshi. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[rahulkjoshi]

/assign @dlapcevic

[dlapcevic]

LGTM. Thank you Rahul.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dlapcevic, rahulkjoshi
Once this PR has been reviewed and has the lgtm label, please assign marseel for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• clusterloader2/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dlapcevic]

@rahulkjoshi please assign to @marseel for approval and merging, once you're ready for it.

[rahulkjoshi]

/assign @marseel

[marseel]

@rahulkjoshi @dlapcevic
Can I get a bit more context why are we doing this?
It seems to me that we are creating any arbitrary manifest within DNS measurement (I don't see how these two things are related)
I don't really see what's the point if iwe could do the same thing in yaml test config.
Something like this with NetworkPolicies:

perf-tests/clusterloader2/testing/load/modules/reconcile-objects.yaml

Line 122 in 82625fa

objectTemplatePath: networkpolicy.yaml

One difference I see is that above one creates objects in test-X namespaces rather then the one used by DNS measurement dns-perf-test.
In that case we can either make DNS Measurement to run within regular "test" namespaces or we can add option to Phase to specify namespace names rather than range of namespaces that are auto-created: https://github.com/marseel/perf-tests/blob/83f46c7db453955aa142c1c1bf42311846fa270a/clusterloader2/api/types.go#L100

[dlapcevic]

The purpose is in the description:

Provides the capability to apply additional manifests before starting a DNS performance test. This can be used to install other features that might need to be scaled tested (e.g. egress gateways, network policies, etc.)

We want to be able to apply custom manifests that are related to DNS. I don’t see a simple way to do it without having to add these manifests here in the perf-tests repo. It’s much simpler to allow us to pass them in.
However, Marcel might be right that it doesn’t belong within the DNS measurement, and we could move it out to a separate measurement, and run this measurement just before the DNS measurement.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

Details

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.