Skip to content

Conversation

@saschagrunert
Copy link
Member

What type of PR is this?

/kind failing-test

What this PR does / why we need it:

The latest docker-ce-cli package (API version 1.52) is incompatible with the Docker-in-Docker setup in CI, which supports a maximum API version of 1.43. This causes build failures with the error: "client version 1.52 is too new. Maximum supported API version is 1.43"

Docker 24.0.x uses API version 1.43, making it compatible with the current CI DinD environment.

Which issue(s) this PR fixes:

Fixes: #4180

Special notes for your reviewer:

None

Does this PR introduce a user-facing change?

k8s-cloud-builder: pinned docker-ce-cli to version 24.0.x for API 1.43 compatibility

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Nov 13, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 13, 2025
@saschagrunert saschagrunert changed the title WIP: Pin docker-ce-cli to version 24.0.x for API 1.43 compatibility Pin docker-ce-cli to version 24.0.x for API 1.43 compatibility Nov 13, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Nov 13, 2025
@saschagrunert saschagrunert force-pushed the fix-docker-cli-api-version branch from 529fd2e to 069d634 Compare November 13, 2025 09:29
@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 13, 2025
The latest docker-ce-cli package (API version 1.52) is incompatible
with the Docker-in-Docker setup in CI, which supports a maximum API
version of 1.43. This causes build failures with the error:
"client version 1.52 is too new. Maximum supported API version is 1.43"

Docker 24.0.x uses API version 1.43, making it compatible with the
current CI DinD environment.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert saschagrunert force-pushed the fix-docker-cli-api-version branch from 069d634 to 883ffc8 Compare November 13, 2025 09:30
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Nov 13, 2025
@saschagrunert
Copy link
Member Author

/hold

@BenTheElder @dims PTAL

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
Copy link
Member

@BenTheElder BenTheElder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
I guess next we will need a tracking issue to roll forward

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 13, 2025
@saschagrunert
Copy link
Member Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 13, 2025
@k8s-ci-robot k8s-ci-robot merged commit 13a509c into kubernetes:master Nov 13, 2025
12 checks passed
@saschagrunert saschagrunert deleted the fix-docker-cli-api-version branch November 13, 2025 12:38
@saschagrunert
Copy link
Member Author

saschagrunert commented Nov 13, 2025

/lgtm I guess next we will need a tracking issue to roll forward

See: #4184

saschagrunert added a commit to saschagrunert/release that referenced this pull request Nov 13, 2025
The latest docker-ce-cli package (API version 1.52) is incompatible
with the Docker-in-Docker setup in CI, which supports a maximum API
version of 1.43. This causes build failures with the error:
"client version 1.52 is too new. Maximum supported API version is 1.43"

While docker-ce was already pinned to 24.0.x, the docker-ce package
dependency on docker-ce-cli is unversioned, allowing APT to install
the latest docker-ce-cli (currently 29.0.0 with API 1.52) even when
the daemon is pinned.

Docker 24.0.x uses API version 1.43, making it compatible with the
current CI DinD environment.

This is a follow-up to kubernetes#4183 which fixed the same issue for
k8s-cloud-builder.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@dims
Copy link
Member

dims commented Nov 13, 2025

@saschagrunert thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

latest krel image incompatible with CI DinD

4 participants