-
Notifications
You must be signed in to change notification settings - Fork 526
Pin docker-ce-cli to version 24.0.x for API 1.43 compatibility #4183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin docker-ce-cli to version 24.0.x for API 1.43 compatibility #4183
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
529fd2e to
069d634
Compare
The latest docker-ce-cli package (API version 1.52) is incompatible with the Docker-in-Docker setup in CI, which supports a maximum API version of 1.43. This causes build failures with the error: "client version 1.52 is too new. Maximum supported API version is 1.43" Docker 24.0.x uses API version 1.43, making it compatible with the current CI DinD environment. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
069d634 to
883ffc8
Compare
|
/hold @BenTheElder @dims PTAL |
BenTheElder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
I guess next we will need a tracking issue to roll forward
|
/unhold |
See: #4184 |
The latest docker-ce-cli package (API version 1.52) is incompatible with the Docker-in-Docker setup in CI, which supports a maximum API version of 1.43. This causes build failures with the error: "client version 1.52 is too new. Maximum supported API version is 1.43" While docker-ce was already pinned to 24.0.x, the docker-ce package dependency on docker-ce-cli is unversioned, allowing APT to install the latest docker-ce-cli (currently 29.0.0 with API 1.52) even when the daemon is pinned. Docker 24.0.x uses API version 1.43, making it compatible with the current CI DinD environment. This is a follow-up to kubernetes#4183 which fixed the same issue for k8s-cloud-builder. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
|
@saschagrunert thank you! |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
The latest docker-ce-cli package (API version 1.52) is incompatible with the Docker-in-Docker setup in CI, which supports a maximum API version of 1.43. This causes build failures with the error: "client version 1.52 is too new. Maximum supported API version is 1.43"
Docker 24.0.x uses API version 1.43, making it compatible with the current CI DinD environment.
Which issue(s) this PR fixes:
Fixes: #4180
Special notes for your reviewer:
None
Does this PR introduce a user-facing change?