Pin docker-ce-cli to version 24.0.x for API 1.43 compatibility in k8s-ci-builder #4185
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest docker-ce-cli package (API version 1.52) is incompatible with the Docker-in-Docker setup in CI, which supports a maximum API version of 1.43. This causes build failures with the error: "client version 1.52 is too new. Maximum supported API version is 1.43" While docker-ce was already pinned to 24.0.x, the docker-ce package dependency on docker-ce-cli is unversioned, allowing APT to install the latest docker-ce-cli (currently 29.0.0 with API 1.52) even when the daemon is pinned. Docker 24.0.x uses API version 1.43, making it compatible with the current CI DinD environment. This is a follow-up to kubernetes#4183 which fixed the same issue for k8s-cloud-builder. Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
k8s-ci-robot
added
release-note
k8s-ci-robot
added
area/release-eng
Member
Author
|
@BenTheElder @dims PTAL |
cpanato
approved these changes
Nov 13, 2025
k8s-ci-robot
added
the
lgtm
cpanato
approved these changes
Nov 13, 2025
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, saschagrunert The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
/approve |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
This PR pins
docker-ce-clito version 24.0.x in the k8s-ci-builder image to ensure API version 1.43 compatibility with Docker-in-Docker in CI environments.While
docker-cewas already pinned to 24.0.x, thedocker-cepackage has an unversioned dependency ondocker-ce-cli. This allows APT to install the latest availabledocker-ce-cli(currently 29.0.0 with API 1.52), which is incompatible with the DinD setup that only supports API 1.43.Which issue(s) this PR fixes:
Follow-up to #4183
Special notes for your reviewer:
This is the same fix as #4183, but applied to the k8s-ci-builder image instead of k8s-cloud-builder. The k8s-ci-builder image installs
docker-ce(full daemon) while k8s-cloud-builder only installsdocker-ce-cli, but both suffer from the same issue where the CLI can be upgraded to an incompatible version.Does this PR introduce a user-facing change?