add debian trixie and riscv64 support for debian-base#4303
add debian trixie and riscv64 support for debian-base#4303Opvolger wants to merge 1 commit intokubernetes:masterfrom
Conversation
|
Welcome @Opvolger! |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Opvolger The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @Opvolger. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This needs a wider discussion, adding new architectures to the build is expensive in time, compute, storage, etc, and we already have multiple architectures that see extremely low usage rates. This also creates an expectation from all SIGs that this architecture will be supported (especially e.g. SIG Node). Third parties are welcome to override the base images and compile their own releases. /hold cc @kubernetes/sig-release-leads @kubernetes/release-engineering |
|
NOTE: We also do not have any CI resources available for this architecture. |
|
After this pull request: GoogleContainerTools/distroless#2001, I was hoping this base image for risc-v would become a possibility. Many projects use this image as a base. So you have to create patches to replace this Docker image with another one (which does support risc-v). k0s is currently building for risc-v, but CSI providers, for example, don't have risc-v support yet. All code can handle it, but this Docker image is already being used as a base. So you get a project like this: https://github.com/Opvolger/k8s-csi-driver-riscv64/blob/master/patches/csi-driver-iscsi/0001-Change-Dockerfile.patch I was hoping this would be the start of adding risc-v as an architecture. Otherwise we'll continue to have a chicken-and-egg problem: kubernetes/kubernetes#116686 (comment) |
We don't prohibit this, but these images are explicitly base images for the Kubernetes project and there is no documentation suggesting that they're intended to be consumed as a primary release artifact. They're an implementation detail of releasing Kubernetes. Originally they were literally in the main repo, they're only here to more easily manage them across minor releases of Kubernetes and dedupe where possible. External project re-use is not a primary concern and we've e.g. chosen to make breaking changes before without concern for external projects as a result (e.g. recently #4223) Those projects could choose their own images.
This comment is not from a maintainer and doesn't represent an accepted approach, e.g. it skips https://www.kubernetes.dev/docs/guide/platforms/#step-0-engage-with-the-community |
|
Thanks for the contribution @Opvolger! However, adding a new architecture requires going through the platform support process first. We're currently formalizing the platform tier criteria in kubernetes/sig-release#2974, which defines the requirements for adding and maintaining platform support (CI resources, maintainer commitment, ecosystem readiness, etc.). riscv64 would need to meet those criteria before we can add it to our build artifacts. Please follow the platform support guide and engage with the community through that process. Closing this for now. Once the platform tiers are established and riscv64 meets the requirements, a PR like this would be welcome. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Debian Trixie is the successor to Bookworm. One of Trixie's advantages is that it now supports riscv64.
Updated debian-base docker image.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?