Skip to content

add debian trixie and riscv64 support for debian-base#4303

Closed
Opvolger wants to merge 1 commit intokubernetes:masterfrom
Opvolger:debian-base-trixie
Closed

add debian trixie and riscv64 support for debian-base#4303
Opvolger wants to merge 1 commit intokubernetes:masterfrom
Opvolger:debian-base-trixie

Conversation

@Opvolger
Copy link

@Opvolger Opvolger commented Mar 2, 2026

What type of PR is this?

/kind feature

What this PR does / why we need it:

Debian Trixie is the successor to Bookworm. One of Trixie's advantages is that it now supports riscv64.

Updated debian-base docker image.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

add trixie and riscv64 for debian-base image

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject labels Mar 2, 2026
@k8s-ci-robot k8s-ci-robot requested a review from jimangel March 2, 2026 20:13
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Mar 2, 2026
@k8s-ci-robot k8s-ci-robot requested a review from salaxander March 2, 2026 20:13
@k8s-ci-robot
Copy link
Contributor

Welcome @Opvolger!

It looks like this is your first PR to kubernetes/release 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/release has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Opvolger
Once this PR has been reviewed and has the lgtm label, please assign justaugustus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 2, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @Opvolger. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 2, 2026
@BenTheElder
Copy link
Member

This needs a wider discussion, adding new architectures to the build is expensive in time, compute, storage, etc, and we already have multiple architectures that see extremely low usage rates. This also creates an expectation from all SIGs that this architecture will be supported (especially e.g. SIG Node).

Third parties are welcome to override the base images and compile their own releases.

/hold

cc @kubernetes/sig-release-leads @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2026
@BenTheElder
Copy link
Member

NOTE: We also do not have any CI resources available for this architecture.

https://www.kubernetes.dev/docs/guide/platforms/

@Opvolger
Copy link
Author

Opvolger commented Mar 3, 2026

After this pull request: GoogleContainerTools/distroless#2001, I was hoping this base image for risc-v would become a possibility.

Many projects use this image as a base. So you have to create patches to replace this Docker image with another one (which does support risc-v).

k0s is currently building for risc-v, but CSI providers, for example, don't have risc-v support yet. All code can handle it, but this Docker image is already being used as a base.

So you get a project like this: https://github.com/Opvolger/k8s-csi-driver-riscv64/blob/master/patches/csi-driver-iscsi/0001-Change-Dockerfile.patch

I was hoping this would be the start of adding risc-v as an architecture.

Otherwise we'll continue to have a chicken-and-egg problem: kubernetes/kubernetes#116686 (comment)

@BenTheElder
Copy link
Member

BenTheElder commented Mar 3, 2026

Many projects use this image as a base. So you have to create patches to replace this Docker image with another one (which does support risc-v).

We don't prohibit this, but these images are explicitly base images for the Kubernetes project and there is no documentation suggesting that they're intended to be consumed as a primary release artifact.

They're an implementation detail of releasing Kubernetes. Originally they were literally in the main repo, they're only here to more easily manage them across minor releases of Kubernetes and dedupe where possible.

External project re-use is not a primary concern and we've e.g. chosen to make breaking changes before without concern for external projects as a result (e.g. recently #4223)

Those projects could choose their own images.

Otherwise we'll continue to have a chicken-and-egg problem: kubernetes/kubernetes#116686 (comment)

This comment is not from a maintainer and doesn't represent an accepted approach, e.g. it skips https://www.kubernetes.dev/docs/guide/platforms/#step-0-engage-with-the-community

@saschagrunert
Copy link
Member

Ref: kubernetes/sig-release#2974

@saschagrunert
Copy link
Member

Thanks for the contribution @Opvolger! However, adding a new architecture requires going through the platform support process first. We're currently formalizing the platform tier criteria in kubernetes/sig-release#2974, which defines the requirements for adding and maintaining platform support (CI resources, maintainer commitment, ecosystem readiness, etc.).

riscv64 would need to meet those criteria before we can add it to our build artifacts. Please follow the platform support guide and engage with the community through that process.

Closing this for now. Once the platform tiers are established and riscv64 meets the requirements, a PR like this would be welcome.

@Opvolger Opvolger changed the title add debian trixie and riscv64 support for debian-base add debian trixie support for debian-base Mar 5, 2026
@Opvolger Opvolger changed the title add debian trixie support for debian-base add debian trixie and riscv64 support for debian-base Mar 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants