Skip to content

Fix git checkout and kube cross#812

Merged
k8s-ci-robot merged 2 commits into
kubernetes:masterfrom
pivotal-k8s:fix-git-checkout-and-kube-cross
Jul 26, 2019
Merged

Fix git checkout and kube cross#812
k8s-ci-robot merged 2 commits into
kubernetes:masterfrom
pivotal-k8s:fix-git-checkout-and-kube-cross

Conversation

@hoegaarden

@hoegaarden hoegaarden commented Jul 3, 2019

Copy link
Copy Markdown
Contributor

/cc @pswica
/assign @justaugustus

@k8s-ci-robot k8s-ci-robot requested a review from pswica July 3, 2019 13:38
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jul 3, 2019
@justaugustus

justaugustus commented Jul 3, 2019

Copy link
Copy Markdown
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 3, 2019
@justaugustus

justaugustus commented Jul 3, 2019

Copy link
Copy Markdown
Member

/hold
until further notice

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 3, 2019
@justaugustus

justaugustus commented Jul 12, 2019

Copy link
Copy Markdown
Member

@hoegaarden -- can you rebase this?

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@k8s-ci-robot

k8s-ci-robot commented Jul 12, 2019

Copy link
Copy Markdown
Contributor

@hoegaarden: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Details

Reasons for blocking this PR:

[Changes to certain release tools can affect our ability to test, build, and release Kubernetes. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2019
justaugustus
justaugustus requested changes Jul 26, 2019
View reviewed changes

@justaugustus justaugustus left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some microscopic nits here.

Comment thread anago Outdated
Comment thread anago Outdated
Comment thread anago Outdated
Comment thread anago
# Checkout location
logecho -n "Checking out $tree_object: "
logrun -s git checkout $branch_arg $tree_object $branch_point || return 1
local checkout_args=()

@justaugustus justaugustus Jul 26, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment above this giving guidance on how checkout_args, branch_arg, and tree_object should be invoked.
Prefer explicit language here instead of "maybe" or "hopefully".

@hoegaarden hoegaarden Jul 26, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are not invoked ... but anyway, I hope the comment I added clears things up a bit.

Comment thread anago Outdated
@justaugustus

justaugustus commented Jul 26, 2019

Copy link
Copy Markdown
Member

/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 26, 2019
@k8s-ci-robot

k8s-ci-robot commented Jul 26, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hoegaarden, justaugustus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [hoegaarden,justaugustus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Jul 26, 2019
@k8s-ci-robot k8s-ci-robot merged commit 00070cd into kubernetes:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justaugustus justaugustus justaugustus requested changes

@pswica pswica Awaiting requested review from pswica

Assignees

@justaugustus justaugustus

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hoegaarden @justaugustus @k8s-ci-robot