Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make website responsive and don't force min-width #13417

Merged
merged 1 commit into from Mar 26, 2019

Conversation

Projects
None yet
3 participants
@kevinsimper
Copy link
Contributor

commented Mar 26, 2019

No description provided.

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Mar 26, 2019

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kevinsimper

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

I signed it

@netlify

This comment has been minimized.

Copy link

commented Mar 26, 2019

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2be7e06

https://deploy-preview-13417--kubernetes-io-master-staging.netlify.com

@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@kevinsimper 👋 Thanks for submitting this fix. Welcome to Kubernetes! 🎉

Verified on mobile staging (and so much better): https://deploy-preview-13417--kubernetes-io-master-staging.netlify.com/blog/

/lgtm
/approve

@k8s-ci-robot

This comment has been minimized.

Copy link

commented Mar 26, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: zacharysarah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kevinsimper

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

@zacharysarah Thank you 😄 🎉

@k8s-ci-robot k8s-ci-robot merged commit b0b38b0 into kubernetes:master Mar 26, 2019

6 of 8 checks passed

tide Not mergeable.
Details
Pages changed 1654 new files uploaded
Details
Header rules 1 header rule processed
Details
Mixed content No mixed content detected
Details
Redirect rules 505 redirect rules processed
Details
cla/linuxfoundation kevinsimper authorized
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details

@zacharysarah zacharysarah referenced this pull request Mar 26, 2019

Closed

Mobile CSS enforces minimum 1200px width #13412

1 of 2 tasks complete

@kevinsimper kevinsimper deleted the kevinsimper:patch-1 branch Mar 26, 2019

@zacharysarah

This comment has been minimized.

Copy link
Contributor

commented Mar 26, 2019

@kevinsimper If you're interested in joining the org, this PR is one step on the pathway to membership. I'm happy to answer questions if you have them.

@kevinsimper

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

@zacharysarah Thank you for suggesting that, I will definitely take a look!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.