Skip to content

Conversation

@windsonsea
Copy link
Member

@windsonsea windsonsea commented Mar 27, 2025

  • update a bullet list
  • remove redundant spaces in markdown tables. Too long to identify issues included.
  • replace || with \|\| in a markdown code snippet

See preview

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 27, 2025
@k8s-ci-robot k8s-ci-robot requested review from liggitt and sttts March 27, 2025 03:36
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 27, 2025
@netlify
Copy link

netlify bot commented Mar 27, 2025

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8b138fb
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/6850c0274fe0ff0008690117
😎 Deploy Preview https://deploy-preview-50268--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kundan2707
Copy link
Contributor

Preview

@kundan2707
Copy link
Contributor

Changes made content more readable and clean.
Thanks

@kundan2707
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 6f58da0e7e5d7c37d5d447cb42f2cc828941f817

@kundan2707
Copy link
Contributor

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 27, 2025
Copy link
Member

@chenrui333 chenrui333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 16, 2025
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2025
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 17, 2025
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2025
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 21, 2025
@lmktfy
Copy link
Member

lmktfy commented Apr 27, 2025

This seems to be a merge commit. Please revise so it isn't.

/hold
Doesn't look right, even if we're happy with the final tree.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2025
@lmktfy
Copy link
Member

lmktfy commented Jun 16, 2025

@windsonsea can you revise this to be a single commit with a single parent? Try rebasing against main.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 17, 2025
@windsonsea
Copy link
Member Author

/re-open

@windsonsea
Copy link
Member Author

incorrect closed.

@windsonsea
Copy link
Member Author

Oops, something is wrong and this is closed automatically when I run git rebase main and git push.

@windsonsea windsonsea deleted the crden3 branch June 23, 2025 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/documentation Categorizes issue or PR as related to documentation. language/en Issues or PRs related to English language size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants