Skip to content

Update feature gates (English) via automation#53847

Open
singh1203 wants to merge 1 commit intokubernetes:mainfrom
singh1203:gen_reference_feature_gates_markdown
Open

Update feature gates (English) via automation#53847
singh1203 wants to merge 1 commit intokubernetes:mainfrom
singh1203:gen_reference_feature_gates_markdown

Conversation

@singh1203
Copy link
Copy Markdown
Contributor

Description

Syncs all feature gate .md files with Kubernetes

Generated using: ./scripts/releng/update-feature-gates.sh ../featuregates.json

Depends on (merge AFTER):

Issue

Closes:

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sayakmukhopadhyay for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Dec 29, 2025
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 29, 2025
@singh1203
Copy link
Copy Markdown
Contributor Author

cc: @dipesh-rawat @lmktfy

@singh1203
Copy link
Copy Markdown
Contributor Author

Are checks failing due to my changes?
I don't think so https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/695228c6671767000820d9c3#L17

Copy link
Copy Markdown
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR.

To make this build, try a couple of changes:

  • omit all the new feature gates where there is a TODO in the description
    (save those for a future pull request)
  • don't have a stable stage starting at version 1.0 for feature gates that were introduced as deprecated; see AllowDNSOnlyNodeCSR for an example of this

If you preview the changes locally you can see if there are any build errors.
If there are, it's OK to ask for advice about addressing them.

Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
@singh1203 singh1203 force-pushed the gen_reference_feature_gates_markdown branch from 6e7e5e8 to 4688f36 Compare January 17, 2026 16:34
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 17, 2026
@singh1203
Copy link
Copy Markdown
Contributor Author

Thank you for the PR.

To make this build, try a couple of changes:

  • omit all the new feature gates where there is a TODO in the description
    (save those for a future pull request)
  • don't have a stable stage starting at version 1.0 for feature gates that were introduced as deprecated; see AllowDNSOnlyNodeCSR for an example of this

If you preview the changes locally you can see if there are any build errors. If there are, it's OK to ask for advice about addressing them.

Updated this PR to include only feature gates tracked in versioned_feature_list.yaml from k/k

Changes:

  • Removed placeholder feature gates with FIXME/TODO descriptions
  • Kept only gates with existing documentation that received front matter updates
  • Verified locally with make container-serve - build succeeds ✅

New feature gates requiring descriptions will be handled in a separate PR with proper context.
@lmktfy thank you for guidance and feedback 🙇

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 17, 2026

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 4688f36
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/696bb9fe9276cb0008f38b64
😎 Deploy Preview https://deploy-preview-53847--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Jan 17, 2026

/retitle Update feature gates (English) via automation

@k8s-ci-robot k8s-ci-robot changed the title Added all feature gates docs via genfeaturegates utility Update feature gates (English) via automation Jan 17, 2026
Copy link
Copy Markdown
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Even though this PR introduces one new error, the overall changes represent a big improvement.

@@ -1,14 +1,12 @@
---
title: PodReadyToStartContainersCondition
former_titles:
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try to keep this, unless you can show that former_titles metadata isn't actually used.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure!

toVersion: "1.33"
- stage: stable
defaultValue: true
locked: false
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep this, but for that we ought to first update the generator code.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Will keep it

- stage: alpha
defaultValue: false
fromVersion: "1.30"
fromVersion: "1.32"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is incorrect. Read the text to see why.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, for MutatingAdmissionPolicy are you referring to the "existed but no effect" text for v1.30-1.31?

Also YAML shows Alpha from v1.32. So should we use YAML exactly and manually adjust or add logic to preserve historical ranges?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the upstream data are wrong, let's fix it in k/k so that the generated update comes out correct.

Copy link
Copy Markdown
Member

@lmktfy lmktfy Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature gate was available to set in Kubernetes 1.30 and Kubernetes 1.31 and I would be very wary to change what we say retrospectively. The docs were already correct.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I investigated MutatingAdmissionPolicy in k/k, and the v1.30/v1.31 history here was deliberately adjusted so the recorded lifecycle starts at v1.32. Since that change is intentional upstream, do you still want to fix it in k/k so that the generated update comes out correct?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: a1530a875ef8f42edd5b3bf1a9d21cf5537ac8fa

@divya-mohan0209
Copy link
Copy Markdown
Contributor

@singh1203 : Please advise if you'd be able to address comments by @sftim ?

@singh1203
Copy link
Copy Markdown
Contributor Author

@singh1203 : Please advise if you'd be able to address comments by @sftim ?

Yes, I'm working on it and need some clarification, as I mentioned in the reply to @lmktfy's comment.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 23, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants