Update feature gates (English) via automation#53847
Update feature gates (English) via automation#53847singh1203 wants to merge 1 commit intokubernetes:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
cc: @dipesh-rawat @lmktfy |
|
Are checks failing due to my changes? |
lmktfy
left a comment
There was a problem hiding this comment.
Thank you for the PR.
To make this build, try a couple of changes:
- omit all the new feature gates where there is a
TODOin the description
(save those for a future pull request) - don't have a
stablestage starting at version 1.0 for feature gates that were introduced asdeprecated; seeAllowDNSOnlyNodeCSRfor an example of this
If you preview the changes locally you can see if there are any build errors.
If there are, it's OK to ask for advice about addressing them.
Signed-off-by: Saurabh Kumar Singh <singh1203.ss@gmail.com>
6e7e5e8 to
4688f36
Compare
Updated this PR to include only feature gates tracked in versioned_feature_list.yaml from k/k Changes:
New feature gates requiring descriptions will be handled in a separate PR with proper context. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
/retitle Update feature gates (English) via automation |
genfeaturegates utility| @@ -1,14 +1,12 @@ | |||
| --- | |||
| title: PodReadyToStartContainersCondition | |||
| former_titles: | |||
There was a problem hiding this comment.
Try to keep this, unless you can show that former_titles metadata isn't actually used.
| toVersion: "1.33" | ||
| - stage: stable | ||
| defaultValue: true | ||
| locked: false |
There was a problem hiding this comment.
I would keep this, but for that we ought to first update the generator code.
There was a problem hiding this comment.
Okay! Will keep it
| - stage: alpha | ||
| defaultValue: false | ||
| fromVersion: "1.30" | ||
| fromVersion: "1.32" |
There was a problem hiding this comment.
This change is incorrect. Read the text to see why.
There was a problem hiding this comment.
Well, for MutatingAdmissionPolicy are you referring to the "existed but no effect" text for v1.30-1.31?
Also YAML shows Alpha from v1.32. So should we use YAML exactly and manually adjust or add logic to preserve historical ranges?
There was a problem hiding this comment.
If the upstream data are wrong, let's fix it in k/k so that the generated update comes out correct.
There was a problem hiding this comment.
This feature gate was available to set in Kubernetes 1.30 and Kubernetes 1.31 and I would be very wary to change what we say retrospectively. The docs were already correct.
There was a problem hiding this comment.
I investigated MutatingAdmissionPolicy in k/k, and the v1.30/v1.31 history here was deliberately adjusted so the recorded lifecycle starts at v1.32. Since that change is intentional upstream, do you still want to fix it in k/k so that the generated update comes out correct?
|
LGTM label has been added. DetailsGit tree hash: a1530a875ef8f42edd5b3bf1a9d21cf5537ac8fa |
|
@singh1203 : Please advise if you'd be able to address comments by @sftim ? |
Yes, I'm working on it and need some clarification, as I mentioned in the reply to @lmktfy's comment. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Description
Syncs all feature gate
.mdfiles with KubernetesGenerated using:
./scripts/releng/update-feature-gates.sh ../featuregates.jsonDepends on (merge AFTER):
Issue
Closes: