-
Notifications
You must be signed in to change notification settings - Fork 15.4k
Document CSI node ID annotations #54035
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
carlory
wants to merge
1
commit into
kubernetes:dev-1.36
Choose a base branch
from
carlory:follow-up-kk-135676
base: dev-1.36
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -354,6 +354,31 @@ The tutorial illustrates using AppArmor to restrict a container's abilities and | |||||||||||
| The profile specified dictates the set of rules and restrictions that the containerized process must | ||||||||||||
| adhere to. This helps enforce security policies and isolation for your containers. | ||||||||||||
|
|
||||||||||||
| ### csi.alpha.kubernetes.io/node-id (deprecated) {#csi-alpha-kubernetes-io-node-id} | ||||||||||||
|
|
||||||||||||
| Type: Annotation | ||||||||||||
|
|
||||||||||||
| Example: `csi.alpha.kubernetes.io/node-id: "node-12345"` | ||||||||||||
|
|
||||||||||||
| Used on: VolumeAttachments | ||||||||||||
|
|
||||||||||||
| This annotation is used internally to find the node identifier when it can not be obtained from | ||||||||||||
| the `CSINode` object. It is populated by the CSI external-attacher sidecar container before a volume is attached. | ||||||||||||
|
|
||||||||||||
| It provides a fallback mechanism for detaching volumes when a `CSINode` object is not present. | ||||||||||||
|
|
||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||
| ### csi.volume.kubernetes.io/nodeid (deprecated) {#csi-volume-kubernetes-io-nodeid} | ||||||||||||
|
|
||||||||||||
| Type: Annotation | ||||||||||||
|
|
||||||||||||
| Example: `csi.volume.kubernetes.io/nodeid: "node-12345"` | ||||||||||||
|
|
||||||||||||
| Used on: Nodes | ||||||||||||
|
|
||||||||||||
| This annotation was used internally to specify the identifier for a node as understood by the Container Storage Interface (CSI) driver. kubelet populated this annotation by calling the `NodeGetInfo` gRPC method of the CSI driver to retrieve the node ID during the driver registration. And the external-attacher sidecar container read this annotation to get the node ID when attaching or detaching volumes. | ||||||||||||
|
|
||||||||||||
| But it has been deprecated in favor of the `CSINode` object, which provides the same functionality via the `spec.drivers[].nodeID` field. And it needs the csi driver to bump the external-attacher sidecar to v2.2 or later. | ||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Instead of explaining the deprecation, hyperlink to some relevant CSI docs about it. |
||||||||||||
|
|
||||||||||||
| ### deployment.kubernetes.io/desired-replicas | ||||||||||||
|
|
||||||||||||
| Type: Annotation | ||||||||||||
|
|
||||||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(no backticks on API types, per style guide)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@carlory , are you able to address the above suggestion