Remove misleading SYS_PTRACE requirement from share-process-namespace#54890
Open
kovan wants to merge 1 commit intokubernetes:mainfrom
Open
Remove misleading SYS_PTRACE requirement from share-process-namespace#54890kovan wants to merge 1 commit intokubernetes:mainfrom
kovan wants to merge 1 commit intokubernetes:mainfrom
Conversation
Sending signals to processes in other containers sharing a PID namespace does not require the SYS_PTRACE capability. The kill() syscall only needs standard Unix permission checks (same UID or CAP_KILL), not ptrace access. SYS_PTRACE is only needed for ptrace() operations like debugging. Remove the incorrect claim and the unnecessary securityContext from the example YAML to avoid users weakening their pod security posture. Continues the work from kubernetes#50672.
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Thanks. LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SYS_PTRACEcapability is required to signal processes in other containers sharing a process namespacesecurityContextfrom the example YAMLkill()only requires standard Unix permission checks (same UID orCAP_KILL), not ptrace accessThis prevents users from unnecessarily weakening their pod security posture by adding
SYS_PTRACEwhen it is not needed.Continues the work from #50672.
Test plan
kill -HUPworks withoutSYS_PTRACEin a shared process namespace pod🤖 Generated with Claude Code