Skip to content

[zh-tw] Fix: hello minikube page#55052

Merged
k8s-ci-robot merged 4 commits intokubernetes:dev-1.35-zh-tw.1from
tico88612:fix/hello-minikube-page
Mar 26, 2026
Merged

[zh-tw] Fix: hello minikube page#55052
k8s-ci-robot merged 4 commits intokubernetes:dev-1.35-zh-tw.1from
tico88612:fix/hello-minikube-page

Conversation

@tico88612
Copy link
Member

Description

dev-1.35-zh-tw.1 is currently not built successfully, is missing the glossary addon page, and removes shoutcode from markdown comments.

Issue

Follow up #54853
Related #55046

/kind documentation
/area localization
/language zh-tw

Shortcodes should not in markdown comments, otherwise it will return
error.

Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. area/localization General issues or PRs related to localization language/zh-tw Issues or PRs related to Traditional Chinese language labels Mar 25, 2026
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 25, 2026
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 25, 2026
@tico88612
Copy link
Member Author

/cc @yychanlee @apullo777

@k8s-ci-robot
Copy link
Contributor

@tico88612: GitHub didn't allow me to request PR reviews from the following users: yychanlee, apullo777.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

/cc @yychanlee @apullo777

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@netlify
Copy link

netlify bot commented Mar 25, 2026

Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit fc22f08
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/69c4032c0367ad000892ba5c
😎 Deploy Preview https://deploy-preview-55052--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@apullo777
Copy link

Thanks for catching this!

Shortcodes can still be processed even inside <!-- -->, which may break the structure.
The safer approach is to keep both the commented English and the translation inside the shortcode:

{{% tab name="Example" %}}
<!--
English content
-->
中文內容
{{% /tab %}}

We should add this note to our zh-tw guide (similar to zh-cn) to make this clearer going forward!

@yychanlee
Copy link

Nice...
Thanks for checking this.
LGTM

@tico88612
Copy link
Member Author

tico88612 commented Mar 26, 2026

Needs approval and LGTM (David and Peter are not k member currently.)

/assign @tengqm

@tengqm
Copy link
Contributor

tengqm commented Mar 26, 2026

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 26, 2026
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

DetailsGit tree hash: 5e2f8da5bf12983a461790d43d8118f27486db48

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 26, 2026
@k8s-ci-robot k8s-ci-robot merged commit d49b2c0 into kubernetes:dev-1.35-zh-tw.1 Mar 26, 2026
6 checks passed
@tico88612 tico88612 deleted the fix/hello-minikube-page branch March 26, 2026 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. language/zh-tw Issues or PRs related to Traditional Chinese language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants