[zh-tw] Fix: hello minikube page#55052
[zh-tw] Fix: hello minikube page#55052k8s-ci-robot merged 4 commits intokubernetes:dev-1.35-zh-tw.1from
Conversation
Shortcodes should not in markdown comments, otherwise it will return error. Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
Signed-off-by: ChengHao Yang <17496418+tico88612@users.noreply.github.com>
|
/cc @yychanlee @apullo777 |
|
@tico88612: GitHub didn't allow me to request PR reviews from the following users: yychanlee, apullo777. Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Thanks for catching this! Shortcodes can still be processed even inside We should add this note to our zh-tw guide (similar to zh-cn) to make this clearer going forward! |
|
Nice... |
|
Needs approval and LGTM (David and Peter are not k member currently.) /assign @tengqm |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: 5e2f8da5bf12983a461790d43d8118f27486db48 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
dev-1.35-zh-tw.1is currently not built successfully, is missing the glossary addon page, and removes shoutcode from markdown comments.Issue
Follow up #54853
Related #55046
/kind documentation
/area localization
/language zh-tw