[ko] Update Korean translation of CNCF Code of Conduct to v1.3#55182
[ko] Update Korean translation of CNCF Code of Conduct to v1.3#55182S0okJu wants to merge 1 commit intokubernetes:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
LGTM label has been added. DetailsGit tree hash: 59d24caf6ad5c88c1d08d45a9a12237716ea8b84 |
|
/assign |
wonyongg
left a comment
There was a problem hiding this comment.
추가 작업 감사드립니다! 🙏
이번 PR은 다른 Repo에 있는 문서를 website Repo 내에 복사본으로 두고 있는 상태에서, 해당 복사본을 최신 상태로 갱신하는 작업으로 이해하고 있습니다.
실제로 foundation Repo 내 영문 원본과 website Repo 내 영문 복사본 간에도 이러한 구조를 확인할 수 있습니다.
여기서 한 가지 짚고 넘어갈 것이 있습니다. foundation Repo에서의 PR 작업은 한국인 기여자가 아닌 메인테이너 분이 작업하신 것으로 보입니다. 따라서 영어 원문과 한글화 문서 간의 라인 수가 동일하지 않습니다.(또한 해당 영역은 website Repo가 아니기 때문에 한글화 팀의 영향 범위 밖이라고 생각도 듭니다.)
한편, 이번 PR은 website Repo로 복사된 문서를 기준으로 한글화를 진행한 것으로, 이에 따라 라인 수를 맞추는 방향으로 작업한 것으로 이해하고 있습니다.
다른 승인자 및 리뷰어 분들께서는 이 점을 참고해주시기 바랍니다.
저는 LGTM입니다.
/lgtm
lmktfy
left a comment
There was a problem hiding this comment.
It is possible that https://github.com/cncf/foundation/blob/main/code-of-conduct-languages/ko.md is out of date. If so, update the upstream copy first, then sync with that. I am sure that that is the correct order to follow.
If not, update the code of conduct to match the authoritative text from the CNCF.
| @@ -1,71 +1,85 @@ | |||
| <!-- Do not edit this file directly. Get the latest from | |||
| https://github.com/cncf/foundation/blob/main/code-of-conduct.md --> | |||
There was a problem hiding this comment.
That's the wrong link. For Korean, the link is https://github.com/cncf/foundation/blob/main/code-of-conduct-languages/ko.md and the remainder of this file should match the contents of https://github.com/cncf/foundation/blob/main/code-of-conduct-languages/ko.md
It is possible that https://github.com/cncf/foundation/blob/main/code-of-conduct-languages/ko.md is out of date. If so, update the upstream copy first, then sync with that. I am sure that that is the correct order to follow.
There was a problem hiding this comment.
Thanks for the review!
I update the link to https://github.com/cncf/foundation/blob/main/code-of-conduct-languages/ko.md .
For the Code of Conduct changes, I'll discuss this with the localization team.
There was a problem hiding this comment.
I’ve reviewed the English original and the Korean translation, and aside from a few parts, the core content appears to be largely consistent. However, there seem to be some differences in formatting and a few additional sentences, so it would be best to update them together.
Thank you for pointing this out.
There was a problem hiding this comment.
Let me jump in this thread to share some backgrounds :)
CNCF uses translation service to provide localized CoC
So before updating cncf/foundation, it would be good to ask about this topic (I think Nate. W is good person to ask)
|
I recommend cancelling the LGTM; see #55182 (review) |
|
New changes are detected. LGTM label has been removed. |
[ko] Update cncf-code-of-conduct.md
261e470 to
4c29dc2
Compare
|
@lmktfy Thank you all for your comments so far! |
Description
Update the Korean translation of
content/ko/community/static/cncf-code-of-conduct.mdto match the latest English version (1.3).Changes
Reference
Issue
Closes: #55181