Skip to content

Use feature-state shortcode for externalIPs deprecation#55481

Merged
k8s-ci-robot merged 1 commit into
kubernetes:mainfrom
mateenali66:fix/55473-feature-state-externalips
Apr 28, 2026
Merged

Use feature-state shortcode for externalIPs deprecation#55481
k8s-ci-robot merged 1 commit into
kubernetes:mainfrom
mateenali66:fix/55473-feature-state-externalips

Conversation

@mateenali66
Copy link
Copy Markdown
Contributor

@mateenali66 mateenali66 commented Apr 22, 2026

switches the existing caution note in the External IPs section to the feature-state shortcode, matching the pattern already used for Endpoints (line 312 in the same file) and ~10 other field deprecations across the docs. kept the migration advice (external LB controller / Gateway API) as body prose since the shortcode only emits the standard deprecation banner.

Fixes #55473

@k8s-ci-robot k8s-ci-robot added the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 22, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 22, 2026

Welcome @mateenali66!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2026
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 22, 2026
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 22, 2026 •
edited
Loading

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 434ae53
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-io-main-staging/deploys/69ebc594cab7ea0008cf9e0c
😎 Deploy Preview https://deploy-preview-55481--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mateenali66 mateenali66 force-pushed the fix/55473-feature-state-externalips branch from 59c6141 to 1cfd481 Compare April 22, 2026 23:03
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. label Apr 22, 2026
@mateenali66 mateenali66 force-pushed the fix/55473-feature-state-externalips branch from 1cfd481 to de7d6e4 Compare April 22, 2026 23:24
@mateenali66
Copy link
Copy Markdown
Contributor Author

mateenali66 commented Apr 22, 2026 •
edited
Loading

netlify deploy preview is flaking on the current SHA (silent error, null error_message, log_access_attributes: null from their API). the first build on 59c6141 was green and confirmed the shortcode renders: https://deploy-preview-55481--kubernetes-io-main-staging.netlify.app

content is unchanged across pushes (only amended commit metadata). can force-push again or close/reopen if a maintainer wants to re-kick the preview.

@lmktfy
Copy link
Copy Markdown
Member

lmktfy commented Apr 24, 2026

Until we come up with a better option, please force-push essentially the same commit (any minor edit, eg to commit date, is fine). Eventually you should get a preview where Hugo doesn't lock up.

lmktfy
lmktfy reviewed Apr 24, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@lmktfy lmktfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 24, 2026

LGTM label has been added.

DetailsGit tree hash: fa907daa56a35ebc64745485deca402b122e060e

@mateenali66
Use feature-state shortcode for externalIPs deprecation
434ae53 
Switches the existing caution note on the "External IPs" section to
the standard feature-state shortcode, matching the pattern used for
other field deprecations in this file (e.g. Endpoints at line 312)
and across the docs.

Signed-off-by: Mateen Anjum <mateenali66@gmail.com>
@mateenali66 mateenali66 force-pushed the fix/55473-feature-state-externalips branch from de7d6e4 to 434ae53 Compare April 24, 2026 19:33
dipesh-rawat
dipesh-rawat reviewed Apr 28, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dipesh-rawat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2026
@k8s-ci-robot k8s-ci-robot merged commit 94194c6 into kubernetes:main Apr 28, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@lmktfy lmktfy lmktfy left review comments

@katcosgrove katcosgrove Awaiting requested review from katcosgrove

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@lmktfy lmktfy

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Use feature-state shortcode to mark .spec.externalIPs deprecated for Service

4 participants

@mateenali66 @k8s-ci-robot @lmktfy @dipesh-rawat