Skip to content

Add instructions to strip reviewers from localized title blocks#9155

Closed
zacharysarah wants to merge 1 commit into
kubernetes:masterfrom
zacharysarah:i18n-strip-reviewers
Closed

Add instructions to strip reviewers from localized title blocks#9155
zacharysarah wants to merge 1 commit into
kubernetes:masterfrom
zacharysarah:i18n-strip-reviewers

Conversation

@zacharysarah
Copy link
Copy Markdown
Contributor

@zacharysarah zacharysarah commented Jun 19, 2018

This PR adds instructions for localized docs to strip reviewers from title blocks of localized files. This is to avoid bombarding reviewers from an increasing number of translation-specific @mentions.

Ref: kubernetes/community#2221 (comment)

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2018
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: zacharysarah

Assign the PR to them by writing /assign @zacharysarah in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2018
@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 334318f

https://deploy-preview-9155--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 2bea712

https://deploy-preview-9155--kubernetes-io-master-staging.netlify.com

@k8sio-netlify-preview-bot
Copy link
Copy Markdown
Collaborator

Deploy preview for kubernetes-io-master-staging ready!

Built with commit e84c925

https://deploy-preview-9155--kubernetes-io-master-staging.netlify.com

@zacharysarah zacharysarah changed the title [WIP] Add instructions to strip reviewers from localized title blocks Add instructions to strip reviewers from localized title blocks Jun 20, 2018
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 20, 2018
Copy link
Copy Markdown
Contributor

@tengqm tengqm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 20, 2018
@mdlinville
Copy link
Copy Markdown
Contributor

As discussed in Slack, I think there is potential for automation here, so that the translators don't have to touch every file, every time we give them a new BOM, in this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants