fix: remove DNS events from dedup cache#781
Conversation
DNS events don't benefit from deduplication because the system resolver cache already limits DNS traffic at the network layer. Events reaching the eBPF tracer are almost always unique (cache misses or TTL expiry), so the dedup key computation was wasted work. Benchmark data confirms 0% dedup ratio for DNS events. Signed-off-by: Ben <ben@armosec.io>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 46 minutes and 41 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThis change disables DNS event deduplication by removing the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Ben <ben@armosec.io>
Performance Benchmark ResultsNode-Agent Resource Usage
Dedup EffectivenessNo data available. |
Performance Benchmark ResultsNode-Agent Resource Usage
Dedup Effectiveness (AFTER only)
Event Counters
|
DNS events don't benefit from deduplication — the system resolver cache already limits DNS traffic at the network layer, so events reaching the eBPF tracer are almost always unique. Benchmark data confirms 0% dedup ratio for DNS.
Removes the DNS case from
computeEventDedupKeyand the unuseddedupTTLDNSconstant.Summary by CodeRabbit