-
Notifications
You must be signed in to change notification settings - Fork 41
bug: #4001
Copy link
Copy link
Closed
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Metadata
Metadata
Assignees
Labels
help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/bugCategorizes issue or PR as related to a bug.Categorizes issue or PR as related to a bug.
Describe the bug
In
web/src/components/cards/NetworkPolicyCoverage.tsx, theisRefreshingstate is not destructured fromuseCachedPods()and is not passed to theuseCardLoadingStateconfiguration object. This violates the documented component pattern for card loading states as defined in the project's development guidelines.Environment
Steps To Reproduce
web/src/components/cards/NetworkPolicyCoverage.tsx.const { pods, isLoading, isDemoFallback, isFailed, consecutiveFailures } = useCachedPods()useCardLoadingStatecall on line 18 whereisRefreshingis omitted from the options.isRefreshingis completely missing, preventing the card from showing the proper background refresh indicator during data updates.Expected Behavior
The component should extract
isRefreshingfrom the data hook (useCachedPods) and pass it properly touseCardLoadingStateso that background refreshes are indicated smoothly in the UI without triggering the full skeleton loader.Browser Console / Backend Logs
Want to contribute?
Additional Context
Discovered during a code review looking for genuine coding pattern violations regarding
isDemoDataandisRefreshingwiring.