Skip to content

🐛 Fix missing isRefreshing in NetworkPolicyCoverage card#4004

Merged
clubanderson merged 1 commit intomainfrom
fix/network-policy-isrefreshing
Mar 31, 2026
Merged

🐛 Fix missing isRefreshing in NetworkPolicyCoverage card#4004
clubanderson merged 1 commit intomainfrom
fix/network-policy-isrefreshing

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

Summary

  • Destructure isRefreshing from useCachedPods() and pass it to useCardLoadingState() in the NetworkPolicyCoverage card
  • Without this, the card does not show the background refresh indicator when cached data is being updated, inconsistent with the established pattern used by other cards (e.g., WarningEvents, ClusterGroups)

Fixes #4001

Test plan

  • Verify the NetworkPolicyCoverage card shows the refreshing indicator during background data updates
  • Verify no regressions in card loading/skeleton states
  • Verify build passes (npm run build)

Destructure isRefreshing from useCachedPods() and pass it to
useCardLoadingState so the card correctly shows the refreshing
indicator when data is being updated in the background.

Fixes #4001

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings March 31, 2026 15:43
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Mar 31, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Mar 31, 2026

Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit 43f5801
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69cbebb2466723000872eac6
😎 Deploy Preview https://deploy-preview-4004.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow kubestellar-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 31, 2026
@clubanderson clubanderson merged commit f1f5e5a into main Mar 31, 2026
19 of 20 checks passed
@kubestellar-prow kubestellar-prow bot deleted the fix/network-policy-isrefreshing branch March 31, 2026 15:44
@github-actions
Copy link
Copy Markdown
Contributor

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the NetworkPolicyCoverage card’s loading-state wiring so it can display the background refresh indicator during stale-while-revalidate updates, aligning it with the established useCardLoadingState pattern used across other cards.

Changes:

  • Destructures isRefreshing from useCachedPods().
  • Passes isRefreshing into useCardLoadingState() so CardWrapper can show the refresh state while cached data is being updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug:

2 participants