🐛 Fix missing isRefreshing in NetworkPolicyCoverage card#4004
🐛 Fix missing isRefreshing in NetworkPolicyCoverage card#4004clubanderson merged 1 commit intomainfrom
Conversation
Destructure isRefreshing from useCachedPods() and pass it to useCardLoadingState so the card correctly shows the refreshing indicator when data is being updated in the background. Fixes #4001 Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
There was a problem hiding this comment.
Pull request overview
This PR fixes the NetworkPolicyCoverage card’s loading-state wiring so it can display the background refresh indicator during stale-while-revalidate updates, aligning it with the established useCardLoadingState pattern used across other cards.
Changes:
- Destructures
isRefreshingfromuseCachedPods(). - Passes
isRefreshingintouseCardLoadingState()so CardWrapper can show the refresh state while cached data is being updated.
Summary
isRefreshingfromuseCachedPods()and pass it touseCardLoadingState()in theNetworkPolicyCoveragecardWarningEvents,ClusterGroups)Fixes #4001
Test plan
npm run build)