Skip to content

🐛 fix: update EnterpriseComplianceCards test for semantic color tokens#21346

Merged
clubanderson merged 2 commits into
mainfrom
scanner/fix-21343-compliance
Jul 21, 2026
Merged

🐛 fix: update EnterpriseComplianceCards test for semantic color tokens#21346
clubanderson merged 2 commits into
mainfrom
scanner/fix-21343-compliance

Conversation

@clubanderson

@clubanderson clubanderson commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Fixes #21343

Updates the EnterpriseComplianceCards test to expect the semantic color token text-muted-foreground instead of the hardcoded text-gray-500. This aligns with the component's migration to semantic status color tokens as documented in the repo's color system conventions.

🐛 fix: update EnterpriseComplianceCards test to match semantic color …
166b66e 
…tokens

Signed-off-by: KubeStellar Scanner <scanner@kubestellar.io>
Copilot AI review requested due to automatic review settings July 21, 2026 00:35
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Jul 21, 2026
@kubestellar-prow

kubestellar-prow Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mikespreitzer for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Jul 21, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubestellarconsole ready!

Name Link
🔨 Latest commit b2a464a
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/6a5f100fd35029000736f32c
😎 Deploy Preview https://deploy-preview-21346.console-deploy-preview.kubestellar.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.

This is an automated message.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

🐝 Hi @clubanderson! I'm kubestellar-hive[bot], an automation bot for this repo.

Trusted users — org members and contributors with write access — can mention @kubestellar-hive in a comment to trigger repo automation.
On issues, that mention queues an automated fix attempt. On pull requests, it records extra context for existing automation.
This is not an interactive Q&A bot, so mentions should be treated as requests for automation rather than a conversation.

Automation may take a moment to start, and follow-up happens through workflow activity rather than chat replies.

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2026
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

✅ Test Coverage Check

All new source files in this PR have corresponding test files.

Checked web/src/hooks/ and web/src/components/ against origin/main.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

♿ Accessibility Audit (WCAG 2.1 AA)

✅ No WCAG 2.1 AA violations detected in audited routes.

Powered by axe-core. Target: WCAG 2.1 AA compliance.

Copilot AI reviewed Jul 21, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the EnterpriseComplianceCards unit test to assert against a semantic Tailwind color token for the loading text, rather than a hardcoded gray utility class.

Changes:

  • Update the HIPAA card loading-state test to expect text-muted-foreground instead of text-gray-500.

Comment thread web/src/components/cards/__tests__/EnterpriseComplianceCards.test.tsx
Comment on lines 61 to +63
const loadingText = screen.getByText('Loading…');
expect(loadingText).toBeInTheDocument();
expect(loadingText.className).toContain('text-gray-500');
expect(loadingText.className).toContain('text-muted-foreground');
Comment thread web/src/components/cards/__tests__/EnterpriseComplianceCards.test.tsx
Comment on lines 61 to +63
const loadingText = screen.getByText('Loading…');
expect(loadingText).toBeInTheDocument();
expect(loadingText.className).toContain('text-gray-500');
expect(loadingText.className).toContain('text-muted-foreground');
clubanderson
clubanderson commented Jul 21, 2026
View reviewed changes

@clubanderson clubanderson left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (quality review) — minimal, correct test alignment for the design-token migration merged in #21317 (text-gray-500 → text-muted-foreground). Verified text-muted-foreground is a defined Tailwind token in this repo. Note: #21350 has this identical diff bundled with two other test changes — one of those (CreateNamespaceModal) is incorrect. Prefer to merge THIS focused PR and close #21350's compliance-cards piece, or close this if #21350 is trimmed to only correct changes.

quality agent · ACMM L4/L6 full

@clubanderson clubanderson mentioned this pull request Jul 21, 2026
Closed
@clubanderson
clubanderson merged commit bd1fec9 into main Jul 21, 2026
31 of 33 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-21343-compliance branch July 21, 2026 06:22
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@clubanderson clubanderson mentioned this pull request Jul 21, 2026
Merged
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

⏹️ Post-Merge Verification: cancelled

Commit: bd1fec962b219a75a2d6622e7eeb674c0c0fd662
Specs run: Dashboard.spec.ts smoke.spec.ts
Report: https://github.com/kubestellar/console/actions/runs/29806826571

This was referenced Jul 21, 2026
Closed
Closed
Closed
@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Post-merge build verification passed ✅

Both Go and frontend builds compiled successfully against merge commit bd1fec962b219a75a2d6622e7eeb674c0c0fd662.

@clubanderson clubanderson mentioned this pull request Jul 21, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tier/1-lightweight

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

🐛 3 test failure(s) in Coverage Suite run #4365

2 participants

@clubanderson