Skip to content

🐛 Remove concurrency group from coverage suite#4179

Merged
clubanderson merged 1 commit intomainfrom
fix/coverage-no-concurrency
Apr 1, 2026
Merged

🐛 Remove concurrency group from coverage suite#4179
clubanderson merged 1 commit intomainfrom
fix/coverage-no-concurrency

Conversation

@clubanderson
Copy link
Copy Markdown
Collaborator

Concurrency group blocked manual triggers behind scheduled runs. 2-hour schedule with 25-min runtime won't overlap naturally.

Signed-off-by: Andrew Anderson <andy@clubanderson.com>
Copilot AI review requested due to automatic review settings April 1, 2026 15:56
@kubestellar-prow kubestellar-prow bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Apr 1, 2026
@kubestellar-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 1, 2026

Deploy Preview for kubestellarconsole canceled.

Name Link
🔨 Latest commit 61ab3aa
🔍 Latest deploy log https://app.netlify.com/projects/kubestellarconsole/deploys/69cd401bf0820e0008cab30e

@kubestellar-prow kubestellar-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 1, 2026
@clubanderson clubanderson merged commit 42796ba into main Apr 1, 2026
14 of 15 checks passed
@kubestellar-prow kubestellar-prow bot deleted the fix/coverage-no-concurrency branch April 1, 2026 15:56
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 1, 2026

👋 Hey @clubanderson — thanks for opening this PR!

🤖 This project is developed exclusively using AI coding assistants.

Please do not attempt to code anything for this project manually.
All contributions should be authored using an AI coding tool such as:

This ensures consistency in code style, architecture patterns, test coverage,
and commit quality across the entire codebase.


This is an automated message.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GitHub Actions coverage workflow to avoid manual workflow_dispatch runs being serialized behind scheduled runs by removing the workflow-level concurrency group.

Changes:

  • Removed the concurrency group from the coverage workflow.
  • Added a comment explaining why a concurrency group is no longer used.

concurrency:
group: coverage-hourly
cancel-in-progress: false # Never cancel — let runs complete
# No concurrency group — 2-hour schedule won't overlap with 25-min runs
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the workflow-level concurrency means multiple runs (especially concurrent workflow_dispatch + schedule) can execute in parallel and race on the shared side effect of updating the same coverage badge gist. That can lead to the badge showing an older/incorrect percentage depending on which run finishes last.

Consider restoring concurrency in a way that unblocks manual runs without allowing conflicting badge updates (e.g., move concurrency to a dedicated badge-update job, or gate the gist update to scheduled runs / a single concurrency group just for the update).

Suggested change
# No concurrency group — 2-hour schedule won't overlap with 25-min runs
concurrency:
group: coverage-hourly-badge
cancel-in-progress: false

Copilot uses AI. Check for mistakes.
@clubanderson
Copy link
Copy Markdown
Collaborator Author

🔄 Auto-Applying Copilot Code Review

Copilot code review found 1 code suggestion(s) and 0 general comment(s).

@copilot Please apply all of the following code review suggestions:

  • .github/workflows/coverage-hourly.yml (line 11): concurrency: group: coverage-hourly-badge cancel-in-progress: false

Push all fixes in a single commit. Run cd web && npm run build && npm run lint before committing.


Auto-generated by copilot-review-apply workflow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants