🐛 Remove concurrency group from coverage suite#4179
Conversation
Signed-off-by: Andrew Anderson <andy@clubanderson.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellarconsole canceled.
|
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
|
👋 Hey @clubanderson — thanks for opening this PR!
This is an automated message. |
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub Actions coverage workflow to avoid manual workflow_dispatch runs being serialized behind scheduled runs by removing the workflow-level concurrency group.
Changes:
- Removed the
concurrencygroup from the coverage workflow. - Added a comment explaining why a concurrency group is no longer used.
| concurrency: | ||
| group: coverage-hourly | ||
| cancel-in-progress: false # Never cancel — let runs complete | ||
| # No concurrency group — 2-hour schedule won't overlap with 25-min runs |
There was a problem hiding this comment.
Removing the workflow-level concurrency means multiple runs (especially concurrent workflow_dispatch + schedule) can execute in parallel and race on the shared side effect of updating the same coverage badge gist. That can lead to the badge showing an older/incorrect percentage depending on which run finishes last.
Consider restoring concurrency in a way that unblocks manual runs without allowing conflicting badge updates (e.g., move concurrency to a dedicated badge-update job, or gate the gist update to scheduled runs / a single concurrency group just for the update).
| # No concurrency group — 2-hour schedule won't overlap with 25-min runs | |
| concurrency: | |
| group: coverage-hourly-badge | |
| cancel-in-progress: false |
🔄 Auto-Applying Copilot Code ReviewCopilot code review found 1 code suggestion(s) and 0 general comment(s). @copilot Please apply all of the following code review suggestions:
Push all fixes in a single commit. Run Auto-generated by copilot-review-apply workflow. |
Concurrency group blocked manual triggers behind scheduled runs. 2-hour schedule with 25-min runtime won't overlap naturally.