Skip to content

🐛 Remove concurrency group from coverage suite #4179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clubanderson merged 1 commit into from
Apr 1, 2026
Merged

🐛 Remove concurrency group from coverage suite #4179

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/coverage-hourly.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,7 @@ on:
- cron: '15 */2 * * *' # Every 2 hours at :15 (run takes ~25 min)
workflow_dispatch:

concurrency:
group: coverage-hourly
cancel-in-progress: false # Never cancel — let runs complete
# No concurrency group — 2-hour schedule won't overlap with 25-min runs
Copy link

Copilot AI Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the workflow-level concurrency means multiple runs (especially concurrent workflow_dispatch + schedule) can execute in parallel and race on the shared side effect of updating the same coverage badge gist. That can lead to the badge showing an older/incorrect percentage depending on which run finishes last.

Consider restoring concurrency in a way that unblocks manual runs without allowing conflicting badge updates (e.g., move concurrency to a dedicated badge-update job, or gate the gist update to scheduled runs / a single concurrency group just for the update).

Suggested change
# No concurrency group — 2-hour schedule won't overlap with 25-min runs
concurrency:
group: coverage-hourly-badge
cancel-in-progress: false

Copilot uses AI. Check for mistakes.

permissions:
contents: read
Expand Down
Loading