[quality] add DocsFooter.tsx tests (0% → 60%) - #6766
Conversation
Refs #6703 Adds 8 vitest tests covering DocsFooter.tsx: - pre-mount dark chrome render - mounted render with dark theme - mounted render with light theme - handleSubscribe empty / whitespace / valid email paths - back-to-top useEffect early-return path - unmount cleanup Branch coverage: 95.94%. Statement coverage: 60% (up from 0%). The uncovered lines (33-59) are the back-to-top toggle/click paths; they are gated by an initial mounted=false render that returns a tree without #back-to-top, so document.getElementById returns null and the effect early-returns permanently — an existing latent bug in the component, not a test gap. Signed-off-by: kubestellar-hive[bot] <223556219+Copilot@users.noreply.github.com>
|
Important Held for human sign-off on the direction, not on the code. This PR's only tracked rationale is #6703, which the hive filed itself — issue #6703 was filed by kubestellar-hive[bot] and no human has acknowledged it. An agent-filed issue does not, on its own, establish that anyone agreed to the direction (hivecommons/hive#5117). The change may well be right; nothing here is a review of it. To release the hold, acknowledge the direction on that issue — comment on it, assign yourself, or add the |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for kubestellar-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi @kubestellar-hive[bot]. Thanks for your PR. I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Thank you for your contribution! Your PR has been merged. Check out what's new:
Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey |
Test Improvement
Adds 8 vitest tests for
src/components/docs/DocsFooter.tsx(baseline 0% coverage).Covers:
handleSubscribeempty / whitespace-only / valid email pathsCoverage: statements 0% → 60%, branches 0% → 95.94%.
Note on uncovered lines (33-59): the back-to-top toggle/click paths are gated by an initial
mounted=falserender that returns a tree without#back-to-top. Because the effect has[]deps,document.getElementById("back-to-top")returns null once and the effect early-returns permanently — this is a latent bug in the component itself, not a test gap.Refs #6703
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-opus-4.7