Skip to content

[quality] add DocsFooter.tsx tests (0% → 60%) - #6766

Merged
kubestellar-hive[bot] merged 1 commit into
mainfrom
quality/docsfooter-tests-1788706607
Sep 11, 2026
Merged

[quality] add DocsFooter.tsx tests (0% → 60%)#6766
kubestellar-hive[bot] merged 1 commit into
mainfrom
quality/docsfooter-tests-1788706607

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Test Improvement

Adds 8 vitest tests for src/components/docs/DocsFooter.tsx (baseline 0% coverage).

Covers:

  • pre-mount dark chrome render
  • mounted render with dark theme
  • mounted render with light theme
  • handleSubscribe empty / whitespace-only / valid email paths
  • back-to-top useEffect early-return branch
  • unmount without throwing

Coverage: statements 0% → 60%, branches 0% → 95.94%.

Note on uncovered lines (33-59): the back-to-top toggle/click paths are gated by an initial mounted=false render that returns a tree without #back-to-top. Because the effect has [] deps, document.getElementById("back-to-top") returns null once and the effect early-returns permanently — this is a latent bug in the component itself, not a test gap.

Refs #6703


Filed by quality agent (ACMM L4/L6 — full mode)

— hive: agent=quality backend=copilot model=claude-opus-4.7

Refs #6703

Adds 8 vitest tests covering DocsFooter.tsx:
- pre-mount dark chrome render
- mounted render with dark theme
- mounted render with light theme
- handleSubscribe empty / whitespace / valid email paths
- back-to-top useEffect early-return path
- unmount cleanup

Branch coverage: 95.94%. Statement coverage: 60% (up from 0%).
The uncovered lines (33-59) are the back-to-top toggle/click paths;
they are gated by an initial mounted=false render that returns a
tree without #back-to-top, so document.getElementById returns null
and the effect early-returns permanently — an existing latent bug
in the component, not a test gap.

Signed-off-by: kubestellar-hive[bot] <223556219+Copilot@users.noreply.github.com>
@kubestellar-hive

Copy link
Copy Markdown
Contributor Author

Important

Held for human sign-off on the direction, not on the code.

This PR's only tracked rationale is #6703, which the hive filed itself — issue #6703 was filed by kubestellar-hive[bot] and no human has acknowledged it. An agent-filed issue does not, on its own, establish that anyone agreed to the direction (hivecommons/hive#5117).

The change may well be right; nothing here is a review of it. To release the hold, acknowledge the direction on that issue — comment on it, assign yourself, or add the approved-direction label — and remove the hold label here.

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Sep 6, 2026
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Sep 6, 2026

Copy link
Copy Markdown

Deploy Preview for kubestellar-docs ready!

Name Link
🔨 Latest commit 1fceb67
🔍 Latest deploy log https://app.netlify.com/projects/kubestellar-docs/deploys/6a9d7f684947bf0008505494
😎 Deploy Preview https://deploy-preview-6766--kubestellar-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubestellar-prow kubestellar-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 6, 2026
@kubestellar-prow

Copy link
Copy Markdown

Hi @kubestellar-hive[bot]. Thanks for your PR.

I'm waiting for a kubestellar member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubestellar-prow kubestellar-prow Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 6, 2026
@clubanderson clubanderson removed the hold label Sep 11, 2026
@clubanderson

Copy link
Copy Markdown
Member

Direction acknowledged by hub admin (approved-direction added on #6703); releasing the #5117 hold. This hive runs at ACMM L6 and may act on its own findings.

@kubestellar-hive
kubestellar-hive Bot merged commit 731922b into main Sep 11, 2026
14 of 17 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the quality/docsfooter-tests-1788706607 branch September 11, 2026 16:59
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

Check out what's new:

Stay connected: Slack #kubestellar-dev | Multi-Cluster Survey

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

copilot dco-signoff: yes Indicates the PR's author has signed the DCO. frontend needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. typescript

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants