Skip to content

Conversation

@AdamJ
Copy link
Contributor

@AdamJ AdamJ commented Jul 11, 2018

This PR is for the redesign of KubeVirt.io. Currently in development, a demo of the work can be seen here: http://kvdeml-kv-demo.1d35.starter-us-east-1.openshiftapps.com/.

The design document can be found here: KubeVirt.io Design

As part of the redesign, the following features are being added:

  • discussions on blog posts through Disqus
  • a live Twitter feed

@scollier
Copy link
Contributor

@mindreeper2420 Nice work here!

I noticed that the disqus comment section wasn't enabled on each blog post. For example, it's here:

http://kvdeml-kv-demo.1d35.starter-us-east-1.openshiftapps.com/2018/KVM-Using-Device-Plugins.html

but not here:

http://kvdeml-kv-demo.1d35.starter-us-east-1.openshiftapps.com/2018/Non-Dockerized-Build.html

@AdamJ
Copy link
Contributor Author

AdamJ commented Jul 12, 2018

@scollier I did that just to test out having some pages with comments and some without. Also to make sure it was something we wanted before going back and adding it to all of the blogs. I'll add Disqus to all of them as part of my next update, now that I know it worked as intended.

I've enabled it through a simple trigger, so any blog post can have comments or not, depending on the type of post.

@AdamJ
Copy link
Contributor Author

AdamJ commented Jul 12, 2018

In the latest update, I've add the Disqus piece to each blog post, update the Readme to include instructions for adding Posts and Pages and returned deleted images that caused broken links.

Copy link
Member

@fabiand fabiand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Thank you for this high-fidelity update.

There are some smaller issues, but they are non blocking to me, and I would get to them with issues, once this bigger change is merged.

IOW This change is way good enough for me to get it merged, the small issues are non blockers.

@AdamJ
Copy link
Contributor Author

AdamJ commented Jul 13, 2018

Looking for thoughts on different pagination styles.

The first is a basic "New" / "Old" style, with page X of Y in the middle.
screen shot 2018-07-13 at 2 42 40 pm
screen shot 2018-07-13 at 2 42 45 pm
screen shot 2018-07-13 at 2 42 50 pm

The second displays all of the pages by number, allowing the user to jump to a specific page (though they do not know what is on that page until they see it).

  • variation 1
    screen shot 2018-07-13 at 2 47 18 pm
    screen shot 2018-07-13 at 2 47 32 pm
    screen shot 2018-07-13 at 2 47 26 pm

  • variation 2
    screen shot 2018-07-13 at 2 45 41 pm
    screen shot 2018-07-13 at 2 48 09 pm
    screen shot 2018-07-13 at 2 45 24 pm

@rmohr
Copy link
Member

rmohr commented Jul 16, 2018

Will the user-guide also be prominently linked?

@rmohr
Copy link
Member

rmohr commented Jul 16, 2018

I would have expected that the Docs section is the user-guide. Except with maybe different css style.

@AdamJ
Copy link
Contributor Author

AdamJ commented Jul 16, 2018

@rmohr we're still discussing how to best handle the user guide - whether to incorporate it fully into the kubevirt.io site (not as a separate subdomain), or put some highlights and then link off to the full documentation.

@fabiand
Copy link
Member

fabiand commented Jul 16, 2018

whether to incorporate it fully into the kubevirt.io site (not as a separate subdomain),

I suppose this is meant in the sense of displaying it in the conext of the website.
But not in the sense of "merging the content" into the website.
Correct?

Just making sure, as the user-guide is a separately consumable piece.

@aglitke
Copy link
Member

aglitke commented Jul 16, 2018

Great update!

  • I like the new kubevirt logo. It would be nice to see it larger on the main landing page

@AdamJ
Copy link
Contributor Author

AdamJ commented Jul 16, 2018

@fabiand That is the question - is the current user guide site moved into this (as there is a docs section), or are the primary areas (Installation, Usage, Workload, Authorization and Additional Resources) are just used as direct links into the user guide.

I've recently pushed an update for the Installation and Additional Resources sections that are the opener of that section, but then link to the user guide at the end. There is also now a link directly to the User Guide from the Docs sidebar.

@fabiand
Copy link
Member

fabiand commented Jul 16, 2018

I just focused on this part, and I think to me this is fine.

We would still have a small overlap between the user-guide and the parts in the website, but that's maybe acceptable.
In the end we link to the user-guide which is a good redirection. Thus good to me as it is right now,

@rmohr
Copy link
Member

rmohr commented Jul 17, 2018

I don't see the reason for a duplicate docs section at all. Why can't "Docs" point to the user-guide?

@rmohr
Copy link
Member

rmohr commented Jul 17, 2018

And btw. really nice work, regarding the redesign. It is just very important to concentrate installations guides, ... to avoid outdated information.

@scollier
Copy link
Contributor

@jasonbrooks Please see the conversation here about the user guide.

@jasonbrooks
Copy link
Contributor

For now, we can have docs nav item link to the user guide, and then move to integrate them as a second step.

I took a look at putting the user guide into the main site, like this: http://kubevirtgithubio-kubevirt-test.6923.rh-us-east-1.openshiftapps.com/docs/introduction/, it's in my fork at https://github.com/jasonbrooks/kubevirt.github.io/tree/docs. We can do something like this to integrate the docs.

@AdamJ
Copy link
Contributor Author

AdamJ commented Jul 17, 2018

@jasonbrooks I've updated the navigation to have the "Docs" link navigate directly to the User Guide.

I took a look at your demo & fork, and it looks good. Agreed that moving this to a second step, rather than including it in the redesign, is the best course of action.

@scollier
Copy link
Contributor

@mindreeper2420 @jasonbrooks I think the integration of the docs looks great. Nice work there.

@AdamJ
Copy link
Contributor Author

AdamJ commented Jul 18, 2018

@scollier This is all set for merging. I've rebased the commits down to one and have finished the design reviews.

@fabiand fabiand merged commit 8a67bcc into kubevirt:master Jul 18, 2018
@fabiand
Copy link
Member

fabiand commented Jul 18, 2018

@mindreeper2420 thank you very much!

Please let's make some noise.

Side note - maybe we can update the style of the user-guide to be more aligned with the web site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants