-
Notifications
You must be signed in to change notification settings - Fork 137
feat(redesign): redesign of KubeVirt.io #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@mindreeper2420 Nice work here! I noticed that the disqus comment section wasn't enabled on each blog post. For example, it's here: http://kvdeml-kv-demo.1d35.starter-us-east-1.openshiftapps.com/2018/KVM-Using-Device-Plugins.html but not here: http://kvdeml-kv-demo.1d35.starter-us-east-1.openshiftapps.com/2018/Non-Dockerized-Build.html |
|
@scollier I did that just to test out having some pages with comments and some without. Also to make sure it was something we wanted before going back and adding it to all of the blogs. I'll add Disqus to all of them as part of my next update, now that I know it worked as intended. I've enabled it through a simple trigger, so any blog post can have comments or not, depending on the type of post. |
|
In the latest update, I've add the Disqus piece to each blog post, update the Readme to include instructions for adding Posts and Pages and returned deleted images that caused broken links. |
fabiand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Thank you for this high-fidelity update.
There are some smaller issues, but they are non blocking to me, and I would get to them with issues, once this bigger change is merged.
IOW This change is way good enough for me to get it merged, the small issues are non blockers.
|
Will the user-guide also be prominently linked? |
|
I would have expected that the |
|
@rmohr we're still discussing how to best handle the user guide - whether to incorporate it fully into the kubevirt.io site (not as a separate subdomain), or put some highlights and then link off to the full documentation. |
I suppose this is meant in the sense of displaying it in the conext of the website. Just making sure, as the user-guide is a separately consumable piece. |
|
Great update!
|
|
@fabiand That is the question - is the current user guide site moved into this (as there is a docs section), or are the primary areas (Installation, Usage, Workload, Authorization and Additional Resources) are just used as direct links into the user guide. I've recently pushed an update for the Installation and Additional Resources sections that are the opener of that section, but then link to the user guide at the end. There is also now a link directly to the User Guide from the Docs sidebar. |
|
I just focused on this part, and I think to me this is fine. We would still have a small overlap between the user-guide and the parts in the website, but that's maybe acceptable. |
|
I don't see the reason for a duplicate docs section at all. Why can't "Docs" point to the user-guide? |
|
And btw. really nice work, regarding the redesign. It is just very important to concentrate installations guides, ... to avoid outdated information. |
|
@jasonbrooks Please see the conversation here about the user guide. |
|
For now, we can have docs nav item link to the user guide, and then move to integrate them as a second step. I took a look at putting the user guide into the main site, like this: http://kubevirtgithubio-kubevirt-test.6923.rh-us-east-1.openshiftapps.com/docs/introduction/, it's in my fork at https://github.com/jasonbrooks/kubevirt.github.io/tree/docs. We can do something like this to integrate the docs. |
|
@jasonbrooks I've updated the navigation to have the "Docs" link navigate directly to the User Guide. I took a look at your demo & fork, and it looks good. Agreed that moving this to a second step, rather than including it in the redesign, is the best course of action. |
|
@mindreeper2420 @jasonbrooks I think the integration of the docs looks great. Nice work there. |
|
@scollier This is all set for merging. I've rebased the commits down to one and have finished the design reviews. |
|
@mindreeper2420 thank you very much! Please let's make some noise. Side note - maybe we can update the style of the user-guide to be more aligned with the web site. |









This PR is for the redesign of KubeVirt.io. Currently in development, a demo of the work can be seen here: http://kvdeml-kv-demo.1d35.starter-us-east-1.openshiftapps.com/.
The design document can be found here: KubeVirt.io Design
As part of the redesign, the following features are being added: