fix(terrain-viewer): use Pointer Lock for drag pan and tilt#195
Closed
kui wants to merge 1 commit into
Closed
Conversation
Without Pointer Lock, drag-pan and drag-tilt stall once the cursor reaches the window edge because the OS clamps further pointer movement. Request Pointer Lock on left/middle mousedown so movementX/Y keeps flowing regardless of cursor position, and release the lock once no relevant button remains pressed. Document-level mouseup also cleans up if the browser drops the lock unexpectedly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
movementX/Y, but once the OS cursor reaches the window edge no more motion is delivered and the drag stalls.Test plan
deno task ci:fmt-checkdeno task ci:lintdeno task ci:type-checkdeno task test