ci: cover backend-abstraction branch - #181
Closed
kunchenguid wants to merge 2 commits into
Closed
Conversation
Widen push and pull_request triggers in ci.yml and no-mistakes-required.yml so phase PRs targeting backend-abstraction get the same CI and PR enforcement as main.
Owner
Author
|
Closing unmerged: the integration-branch rollout was reverted in favor of small incremental merges to main, so this trigger widening is no longer needed. |
This was referenced Aug 6, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
Widen firstmate's GitHub Actions triggers so the long-lived integration branch backend-abstraction gets the same CI and PR enforcement as main. Phase PRs for the multi-phase runtime-backend abstraction rollout will target backend-abstraction instead of main, and today neither workflow fires for PRs to a non-main base. Exact scope: in ci.yml change on.push.branches and on.pull_request.branches from [main] to [main, backend-abstraction]; in no-mistakes-required.yml add backend-abstraction alongside main under on.pull_request.branches. No other changes—no job content, permissions, or concurrency edits.
What Changed
backend-abstractionrun alongsidemain.backend-abstractionto theRequire no-mistakespull request branch filter.mainandbackend-abstraction.Risk Assessment
✅ Low: Captain, the diff is limited to adding backend-abstraction to existing GitHub Actions branch filters, with no job, permission, or enforcement logic changes.
Testing
Captain, the baseline behavior suite was already green; the focused workflow validation also passed and produced evidence showing CI plus Require no-mistakes now run for
backend-abstractionwhile non-trigger workflow content stayed unchanged.Evidence: Workflow trigger event matrix
Evidence: Workflow trigger scope diff
Pipeline
Updates from git push no-mistakes
✅ **intent** - passed
✅ No issues found.
✅ **Rebase** - passed
✅ No issues found.
✅ **Review** - passed
✅ No issues found.
✅ **Test** - passed
✅ No issues found.
command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"Baseline provided by the gate:command -v tmux >/dev/null || { echo "tmux is required for e2e tests" >&2; exit 1; }; tmux -V; rc=0; for t in tests/*.test.sh; do echo "== $t =="; bash "$t" || rc=1; done; exit "$rc"Reviewed target diff withgit diff --color=never 1bc8842d2629a9f6497003e544296aa07d787639..f582241d5720024714df74a720f2cf83afc073e8 -- .github/workflows/ci.yml .github/workflows/no-mistakes-required.ymlRan a focused Python/PyYAML workflow-trigger validation that compared base vs target, asserted changed files were limited to the two workflows, asserted non-branch-filter workflow content was unchanged, and simulated push / pull_request branch matching formain,backend-abstraction, andfeature/example✅ **Document** - passed
✅ No issues found.
✅ **Lint** - passed
✅ No issues found.
✅ **Push** - passed
✅ No issues found.