Skip to content

feat(spawn): add cb harness adapter for account-B crewmates - #40

Closed
jwalin-shah wants to merge 2 commits into
kunchenguid:mainfrom
jwalin-shah:fm/cb-harness-2w
Closed

feat(spawn): add cb harness adapter for account-B crewmates#40
jwalin-shah wants to merge 2 commits into
kunchenguid:mainfrom
jwalin-shah:fm/cb-harness-2w

Conversation

@jwalin-shah

Copy link
Copy Markdown

Adds the cb account as a verified crewmate harness.

Changes

  • bin/fm-spawn.sh: add cb case to launch_template() and to the turn-end hook case "$HARNESS" block
  • AGENTS.md: add cb adapter entry (section 4) noting it mirrors claude facts; marked needs-smoke-test

Notes

cb is ~/bin/claude-rollover run b --dangerously-skip-permissions — same Claude Code CLI as claude/pioneer, different account (account B, Pro OAuth). Harness facts are identical to claude: esc to interrupt, /exit, /<skill>.

…NTS.md

- fm-spawn: add pioneer harness template (cpion launch command) and include
  pioneer in the claude* turn-end hook branch so Stop hooks wire correctly
- fm-teardown: append structured outcome entry to data/learn-log.md on every
  teardown, recording task id, kind, mode, project, last status, and report
  summary for fleet-level reflection
- AGENTS.md: tighten ~27 lines across sections 1/4/6/8/9 without dropping
  any operational rules (fleet-sync exception, pi extension internals,
  project memory ownership, watcher guard, escalation list)
- Add cb launch template to fm-spawn.sh: launches via 'cb "$(cat __BRIEF__)"'
- Add cb to turn-end hook case alongside claude* and pioneer
- Document cb as ADDED in AGENTS.md section 4 harness table
  (needs smoke-test spawn for full verification)
- cb inherits all claude adapter facts (busy signature, exit, interrupt,
  skill invocation) since it wraps the same claude CLI under account B

No change needed to fm-harness.sh: the crew command echoes config/crew-harness
verbatim, so 'cb' already resolves correctly without a detection entry.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d020fc5a22

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bin/fm-spawn.sh
Comment on lines +73 to +74
pioneer) printf '%s' 'cpion "$(cat __BRIEF__)"' ;;
cb) printf '%s' 'cb "$(cat __BRIEF__)"' ;;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep unverified adapters behind the raw-launch path

Captain, this makes cb and pioneer first-class launch templates, so config/crew-harness=cb/pioneer or a per-task override will dispatch work through them without the raw-launch verification path. That conflicts with the adapter contract in AGENTS.md that says never dispatch an unverified adapter, and the new cb docs themselves still say it “Needs a smoke-test spawn”; pioneer has no matching documented adapter entry at all. Until these are empirically verified and documented, accepting them here can silently route real tasks to an adapter whose trust prompts, turn-end hook, or command availability have not been validated.

Useful? React with 👍 / 👎.

@jwalin-shah
jwalin-shah deleted the fm/cb-harness-2w branch June 27, 2026 02:53
@kunchenguid

Copy link
Copy Markdown
Owner

Closing WITHOUT merging as a temporary, reversible release-coordination step to create a zero-pipeline window for a no-mistakes pre-release install (v1.35.1-beta.1). The branch fm/macos-dist-update-w9 and its retrofit commits (process-cleanup + Keychain zero-prompt fix + RunAsNode fuse) are preserved. This PR will be reopened or replaced and fully re-validated with the new binary before any merge.

@kunchenguid

Copy link
Copy Markdown
Owner

Please disregard my previous comment on this PR - it was posted here in error and was intended for a different repository's PR. Apologies for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants