Skip to content

Improved windows plugin windowing and popup menus support#121

Merged
kunitoki merged 5 commits into
mainfrom
dev/windows_work
Jul 2, 2026
Merged

Improved windows plugin windowing and popup menus support#121
kunitoki merged 5 commits into
mainfrom
dev/windows_work

Conversation

@kunitoki

@kunitoki kunitoki commented Jul 2, 2026

Copy link
Copy Markdown
Owner

This pull request adds extensive debug logging and improves error handling in several modules, primarily focusing on the popup menu system and Windows-specific windowing code. The changes are aimed at making it easier to trace and diagnose issues during development, especially around popup menu behavior and Direct3D rendering failures. Additionally, there are improvements to Windows path handling and minor code cleanups.

Debug Logging and Diagnostics:

  • Added detailed debug logging throughout the PopupMenu class to trace menu interactions, submenu visibility, mouse events, and dismissal logic. This should greatly aid in tracking down UI bugs and understanding menu state transitions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]
  • Added debug output for Direct3D swap chain creation and present calls, as well as error cases for device removal or reset, making graphics debugging on Windows more transparent. [1] [2] [3]

Windows-Specific Improvements:

  • Improved Windows path handling by ensuring UNC paths are correctly prefixed for long path support in yup_Files_windows.cpp.
  • Enhanced SDL2 window creation on Windows: if a parent window is provided, a custom window class is registered and used to avoid SDL-specific window procedure issues, improving compatibility and stability for child windows.

Code Quality and Minor Fixes:

  • Changed a framerate redraw value from integer 0 to floating-point 0.0f for type correctness in PluginEditorWindow.h.
  • Minor cleanup in submenu logic by removing an unnecessary assignment to parentMenu.

These changes collectively improve the reliability and debuggability of the UI and graphics systems, especially on Windows platforms.

@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.23%. Comparing base (22cb1fc) to head (26e61fb).

Files with missing lines Patch % Lines
modules/yup_gui/menus/yup_PopupMenu.cpp 0.00% 3 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #121      +/-   ##
==========================================
- Coverage   79.23%   79.23%   -0.01%     
==========================================
  Files         681      681              
  Lines       67363    67361       -2     
==========================================
- Hits        53377    53375       -2     
  Misses      13986    13986              
Files with missing lines Coverage Δ
modules/yup_gui/menus/yup_PopupMenu.cpp 41.51% <0.00%> (+0.09%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 22cb1fc...26e61fb. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kunitoki kunitoki merged commit d7baea7 into main Jul 2, 2026
38 of 39 checks passed
@kunitoki kunitoki deleted the dev/windows_work branch July 2, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant