Improved windows plugin windowing and popup menus support#121
Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #121 +/- ##
==========================================
- Coverage 79.23% 79.23% -0.01%
==========================================
Files 681 681
Lines 67363 67361 -2
==========================================
- Hits 53377 53375 -2
Misses 13986 13986
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds extensive debug logging and improves error handling in several modules, primarily focusing on the popup menu system and Windows-specific windowing code. The changes are aimed at making it easier to trace and diagnose issues during development, especially around popup menu behavior and Direct3D rendering failures. Additionally, there are improvements to Windows path handling and minor code cleanups.
Debug Logging and Diagnostics:
PopupMenuclass to trace menu interactions, submenu visibility, mouse events, and dismissal logic. This should greatly aid in tracking down UI bugs and understanding menu state transitions. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17]Windows-Specific Improvements:
yup_Files_windows.cpp.Code Quality and Minor Fixes:
0to floating-point0.0ffor type correctness inPluginEditorWindow.h.parentMenu.These changes collectively improve the reliability and debuggability of the UI and graphics systems, especially on Windows platforms.