Add more options to shader bundler#131
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #131 +/- ##
==========================================
+ Coverage 79.44% 79.48% +0.04%
==========================================
Files 703 703
Lines 69666 69695 +29
==========================================
+ Hits 55348 55399 +51
+ Misses 14318 14296 -22
... and 6 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements and flexibility to the shader bundling and transpilation system, mainly focusing on improving the
yup_shader_bundlertool and its integration with CMake. The changes add support for new command-line options, enable advanced SPIR-V compilation controls, and allow for more complex shader bundle configurations, including multi-stage pipelines and custom include paths.Key changes include:
Shader Bundler Tool Enhancements
yup_shader_bundlerto support multiple pipeline stages (vertex, fragment, compute, etc.) via a new--stage <stage> <path>option, and improved CLI usage documentation. Also added support for specifying source and target languages, SPIR-V options, preprocessor defines, and include directories. [1] [2] [3]getPrefixedValueshelper to collect-Dand-Istyle flags for preprocessor defines and include paths.SPIR-V Compilation Controls
SpvOptimizationModeenum and correspondingspirvOptimizationfield inTranspileOptions, enabling explicit control over SPIR-V optimization (none, size, performance), validation, and debug info emission. Updated the transpiler to use these options. [1] [2] [3]#includeresolution during shader compilation. [1] [2]CMake Integration Improvements
yup_add_shader_bundle()CMake helper to accept anOPTIONSargument, allowing arbitrary flags to be forwarded toyup_shader_bundler(e.g.,--spirv-opt,--target-langs,-D,-I). Updated documentation accordingly. [1] [2] [3]Internal Consistency
TranspileOptionsto use the newspirvOptimizationfield instead of the oldspirvOptimizeboolean.These changes collectively make the shader bundling pipeline more robust, configurable, and suitable for advanced rendering workflows.