Skip to content

[CI] Fix nightly Go path and gate publishing on tests - #3211

Merged
ykwd merged 1 commit into
mainfrom
codex/fix-nightly-go-path
Aug 3, 2026
Merged

[CI] Fix nightly Go path and gate publishing on tests#3211
ykwd merged 1 commit into
mainfrom
codex/fix-nightly-go-path

Conversation

@Aionw

@Aionw Aionw commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix the nightly workflow failure from run 30561954622 and prevent untested nightly wheels from being published.

  • Export /usr/local/go/bin through GITHUB_PATH after dependencies.sh installs Go, so the separate build step can compile libetcd_wrapper.so.
  • Make publish-testpypi depend on nightly-test, so failed or cancelled tests skip publishing.

The build failed because dependencies.sh adds Go only to ~/.bashrc, while subsequent GitHub Actions steps do not source that file. The reusable wheel workflow already uses the same GITHUB_PATH propagation and succeeded in the failing nightly run.

Related work: #3137 also touches the nightly wheel matrix, but does not change the Go toolchain path or gate TestPyPI publishing on nightly-test.

Module

  • Transfer Engine (mooncake-transfer-engine)
  • Mooncake Store (mooncake-store)
  • Mooncake EP (mooncake-ep)
  • Mooncake PG (mooncake-pg)
  • Integration (mooncake-integration)
  • P2P Store (mooncake-p2p-store)
  • Python Wheel (mooncake-wheel)
  • Common (mooncake-common)
  • Mooncake RL (mooncake-rl)
  • CI/CD
  • Docs
  • Other

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Breaking change
  • Documentation update
  • Performance improvement
  • Other

How Has This Been Tested?

Test commands:

pre-commit run --files .github/workflows/nightly.yml
bash -n scripts/ci/run_store_go_integration.sh scripts/ci/run_store_rust_smoke.sh scripts/run_tests.sh scripts/build_wheel.sh
git diff --check

Test results:

  • Unit tests pass (not applicable to this workflow-only change)
  • Integration tests pass (requires the GitHub-hosted nightly environment)
  • Manual testing done: reviewed the workflow dependency graph and verified the Go path export precedes the separate build step
  • Targeted pre-commit hooks passed, including YAML validation.
  • A full nightly build was not run locally.
  • actionlint was unavailable; an attempted temporary download was blocked by GitHub release-assets returning HTTP 403.

Checklist

  • I have performed a human self-review of every changed line before marking this draft ready
  • I have formatted my code using ./scripts/code_format.sh (not applicable to YAML; targeted pre-commit passed)
  • I have run pre-commit run --all-files and all hooks pass (touched-file run passed)
  • I have updated the documentation (not applicable; CI-only behavior)
  • I have added tests to prove my changes are effective (workflow behavior requires a remote run)
  • For changes >500 LOC: I have filed an RFC issue (not applicable; 3 changed lines)

AI Assistance Disclosure

  • No AI tools were used
  • AI tools were used (specify below)

OpenAI Codex inspected the failing Actions run and related workflows, implemented the scoped YAML fixes, ran targeted validation, and prepared this draft PR. The human submitter must review every changed line and be able to defend the change end-to-end before marking it ready.

@Aionw
Aionw marked this pull request as ready for review July 31, 2026 02:57
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ykwd ykwd left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The failed CI is unrelated to this PR

@ykwd
ykwd merged commit eaa6c79 into main Aug 3, 2026
26 of 30 checks passed
@zhyncs
zhyncs deleted the codex/fix-nightly-go-path branch August 4, 2026 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants