[CI] Fix nightly Go path and gate publishing on tests - #3211
Merged
Conversation
Aionw
marked this pull request as ready for review
July 31, 2026 02:57
Aionw
requested review from
Ann-1024,
luketong777,
stmatengss and
ykwd
as code owners
July 31, 2026 02:57
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
ykwd
approved these changes
Aug 3, 2026
ykwd
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. The failed CI is unrelated to this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix the nightly workflow failure from run 30561954622 and prevent untested nightly wheels from being published.
/usr/local/go/binthroughGITHUB_PATHafterdependencies.shinstalls Go, so the separate build step can compilelibetcd_wrapper.so.publish-testpypidepend onnightly-test, so failed or cancelled tests skip publishing.The build failed because
dependencies.shadds Go only to~/.bashrc, while subsequent GitHub Actions steps do not source that file. The reusable wheel workflow already uses the sameGITHUB_PATHpropagation and succeeded in the failing nightly run.Related work: #3137 also touches the nightly wheel matrix, but does not change the Go toolchain path or gate TestPyPI publishing on
nightly-test.Module
mooncake-transfer-engine)mooncake-store)mooncake-ep)mooncake-pg)mooncake-integration)mooncake-p2p-store)mooncake-wheel)mooncake-common)mooncake-rl)Type of Change
How Has This Been Tested?
Test commands:
Test results:
actionlintwas unavailable; an attempted temporary download was blocked by GitHub release-assets returning HTTP 403.Checklist
./scripts/code_format.sh(not applicable to YAML; targeted pre-commit passed)pre-commit run --all-filesand all hooks pass (touched-file run passed)AI Assistance Disclosure
OpenAI Codex inspected the failing Actions run and related workflows, implemented the scoped YAML fixes, ran targeted validation, and prepared this draft PR. The human submitter must review every changed line and be able to defend the change end-to-end before marking it ready.