Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 31, 2025

The test target was using -it flags in the docker run command, causing failures in non-interactive environments like CI/CD pipelines.

Changes

  • Removed -it flag from the test target's docker run command
  • Interactive targets (console, shell, guard) retain -it as appropriate
  • Non-interactive targets (test, gem) now consistently omit -it
# Before
test: image
	docker run -it --rm $(LOCAL_LINK) $(PROJECT_NAME) sh -c 'bundle exec rake test && bundle exec rubocop'

# After  
test: image
	docker run --rm $(LOCAL_LINK) $(PROJECT_NAME) sh -c 'bundle exec rake test && bundle exec rubocop'
Original prompt

This section details on the original issue you should resolve

<issue_title>Fix the test target</issue_title>
<issue_description>It should not use -it</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: kwerle <23320+kwerle@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix test target to not use -it Remove -it flag from test target in Makefile Dec 31, 2025
Copilot AI requested a review from kwerle December 31, 2025 02:15
@kwerle kwerle marked this pull request as ready for review December 31, 2025 02:18
@kwerle kwerle merged commit 03aec1a into develop Dec 31, 2025
3 of 4 checks passed
@kwerle kwerle deleted the copilot/fix-test-target-usage branch December 31, 2025 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the test target

2 participants