Skip to content

refactor: revert MnEntryCPtr from shared_ptr to unique_ptr #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thepastaclaw wants to merge 1 commit into from
Closed

refactor: revert MnEntryCPtr from shared_ptr to unique_ptr #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/interfaces/node.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ class MnEntry
virtual const uint256& getProTxHash() const = 0;
};

using MnEntryCPtr = std::shared_ptr<const MnEntry>;
using MnEntryCPtr = std::unique_ptr<const MnEntry>;

//! Interface for a list of masternode entries
class MnList
Expand Down
10 changes: 5 additions & 5 deletions src/node/interfaces.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,29 +161,29 @@ class MnListImpl : public MnList
void forEachMN(bool only_valid, std::function<void(const MnEntryCPtr&)> cb) const override
{
m_list.ForEachMNShared(only_valid, [&cb](const auto& dmn) {
cb(std::make_shared<const MnEntryImpl>(dmn));
cb(std::make_unique<const MnEntryImpl>(dmn));
});
}
MnEntryCPtr getMN(const uint256& hash) const override
{
const auto dmn{m_list.GetMN(hash)};
return dmn ? std::make_shared<const MnEntryImpl>(dmn) : nullptr;
return dmn ? std::make_unique<const MnEntryImpl>(dmn) : nullptr;
}
MnEntryCPtr getMNByService(const CService& service) const override
{
const auto dmn{m_list.GetMNByService(service)};
return dmn ? std::make_shared<const MnEntryImpl>(dmn) : nullptr;
return dmn ? std::make_unique<const MnEntryImpl>(dmn) : nullptr;
}
MnEntryCPtr getValidMN(const uint256& hash) const override
{
const auto dmn{m_list.GetValidMN(hash)};
return dmn ? std::make_shared<const MnEntryImpl>(dmn) : nullptr;
return dmn ? std::make_unique<const MnEntryImpl>(dmn) : nullptr;
}
std::vector<MnEntryCPtr> getProjectedMNPayees(const CBlockIndex* pindex) const override
{
std::vector<MnEntryCPtr> ret;
for (const auto& payee : m_list.GetProjectedMNPayees(pindex)) {
ret.emplace_back(std::make_shared<const MnEntryImpl>(payee));
ret.emplace_back(std::make_unique<const MnEntryImpl>(payee));
}
return ret;
}
Expand Down