Fix v1.1.0 Intel Mac OpenSSL cross-compile and Windows ssh2 build - #25
Merged
Conversation
Run the Intel Mac job natively on macos-15-intel instead of cross-compiling openssl-sys from ARM. Authenticate SFTP with userauth_pubkey_file via a staged key so Windows ssh2 compiles under RUSTFLAGS=-D warnings, and rename the tauri-action input to releaseAssetNamePattern. Co-authored-by: Yukon <baseGame@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the two v1.1.0 Release job failures. Does not retag, bump the version, dispatch Release, or touch published Release assets. PR #23/#24 retention and prune behavior on master is unchanged.
Failure 1: Intel Mac (
openssl-syscross-compile)macos-latestis ARM. The Intel job used--target x86_64-apple-darwin, sossh2/libssh2-sys/openssl-systried to cross-compile and failed (pkg-config has not been configured to support cross-compilation).Change: run Intel natively on
macos-15-intelwith emptyargs/rust-target(same as Windows/Linux). Keep Apple Silicon onmacos-latestwith--target aarch64-apple-darwin.Also rename invalid tauri-action input
assetNamePattern→releaseAssetNamePattern(same pattern). The v1.1.0 log already warned about this.Failure 2: Windows (
RUSTFLAGS: -D warnings)userauth_pubkey_memoryis cfg-gated off on Windows ssh2 (needs OpenSSL). Unusedpathinrestrict_file_permissionsis unix-only.Change: stage the in-memory private key to a restricted temp file and call the portable
userauth_pubkey_fileAPI, then delete the file. SFTP is not stubbed. On non-unix,restrict_file_permissionstakes_path.Type of change
Validation
RUSTFLAGS='-D warnings' rustup run stable cargo test -p remote-core --locked— 46 passedDid not dispatch Release and did not retag
v1.1.0corepack pnpm qualitycorepack pnpm testChecklist