Update Tests For .lastComponentWithoutExetnison#44
Merged
kylef merged 1 commit intokylef:masterfrom Dec 23, 2017
dduan:fix-last-component
Merged
Update Tests For .lastComponentWithoutExetnison#44kylef merged 1 commit intokylef:masterfrom dduan:fix-last-component
kylef merged 1 commit intokylef:masterfrom
dduan:fix-last-component
Conversation
_Background_ A test for this API has been [failing, but only on macOS][0]. This is due to a implementation difference between the closed-source Foundation and its open-source counterpart. Recently, a [patch][1] has been made to the latter to fix this issue. The patch is [included][2] in the upcoming Swift 4.1 release. _Changes_ Add a condition to the test so it passes on both platforms for now. The expectation is that come Swift 4.1, this test will start failing on Linux and the condition will be removed then. [0]: https://travis-ci.org/kylef/PathKit/builds/289637066 [1]: swiftlang/swift-corelibs-foundation#1376 [2]: https://github.com/apple/swift-corelibs-foundation/commits/swift-4.1-branch
kylef
approved these changes
Dec 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
A test for this API has been failing, but only on macOS. This is
due to a implementation difference between the closed-source Foundation
and its open-source counterpart. Recently, a patch has been made to
the latter to fix this issue. The patch is included in the upcoming
Swift 4.1 release.
Changes
Add a condition to the test so it passes on both platforms for now. The
expectation is that come Swift 4.1, this test will start failing on
Linux and the condition will be removed then.