Add project logo (Windows exe icon, README, Linux desktop entry) - #52
Merged
Conversation
Embeds the etr logo as etr.exe's PE icon resource via embed-resource, displays it in README.md, and ships an optional .desktop launcher + icon PNG in the linux-x86_64 release for users who want a menu entry. Assisted-By: Claude Sonnet 5
Dev-dependency only (via criterion's rayon chain, used for benches); not shipped in the built binaries. Fixes the Security Audit CI check. Assisted-By: Claude Sonnet 5
Assisted-By: Claude Sonnet 5
l1a
added a commit
that referenced
this pull request
Jul 10, 2026
Reconcile with #52 (project logo, which took v0.6.3 and already bumped crossbeam-epoch). Bump to v0.6.4, keep the Windows Backspace fix + anyhow advisory bump, and combine NOTES.md. Assisted-By: Claude Opus 4.8 (1M context)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
etr.exe's PE icon resource (Explorer/taskbar) via theembed-resourcecrate, wired inbuild.rsas a Windows-only build-dependency (manifest_optional()since it's cosmetic)..desktoplauncher template +etr-icon-256.pngin thelinux-x86_64release artifacts, for users who want an app-menu entry (not auto-installed).Test plan
just prgate passed (fmt, clippy, 110 tests, man page build, version/NOTES.md header checks)target/debug/etr.exelocally and extracted its icon via .NETSystem.Drawing.Icon— confirmed it renders the etr logo, not a default/blank iconetr --help/etrs --helpand shell completions regenerate cleanlylinux-x86_64only)Assisted-By: Claude Sonnet 5