Skip to content

Conversation

@Andyporras
Copy link
Member

Description

This pull request removes the trackdetail_name_and_title string from the strings.xml file. Initially, this string included "Name and title," which caused confusion as the term "title" is not used consistently throughout the app. The filename configuration allows for customization, such as using the "date and start time" format, making the inclusion of "title" unnecessary and potentially misleading.

Related issues

Pull Request Checklist

  • The PR is proposed to the proper branch.
  • The changes have been tested on the target Android API and minimum Android API.
  • Automated tests have been added (if applicable).
  • The feature is well documented.
  • There is a reference to the original bug report and related work.

Copy link
Member

@jamescr jamescr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why code the textSize 20sp and colorPrimaryText only in this layout and not the others?. This could be a general change to keep the same look and feel in the app and not only here. Instead of adding this visual change in the PR, I suggest opening an issue to propose the change for all the app layouts. Said this, in this PR just submit the changes in string.xml as the title and description of the PR state.

I would appreciate it if you could simplify the commits to one to keep the code history neat and clean 😎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants