Skip to content

Sysfsgpio invert (active_low)#1730

Merged
Bastian-Krause merged 3 commits into
labgrid-project:masterfrom
pmelange:25.0.1-sysfsgpio_active_low
Jul 8, 2026
Merged

Sysfsgpio invert (active_low)#1730
Bastian-Krause merged 3 commits into
labgrid-project:masterfrom
pmelange:25.0.1-sysfsgpio_active_low

Conversation

@pmelange

Copy link
Copy Markdown
Contributor

Description

Adds the invert (active-low) attribute to SysfsGPIO, NetworkSysfsGPIO, MatchedSysfsGPIO, GPIOSysFSExport, GpioDigitalOutputDriver and the GpioDigitalOutput agent.

Updates to the documentation and the sysfsgpio examples

Checklist

  • Documentation for the feature
  • Tests for the feature
  • The arguments and description in doc/configuration.rst have been updated
  • PR has been tested

@pmelange
pmelange force-pushed the 25.0.1-sysfsgpio_active_low branch 2 times, most recently from 7b1cb10 to 03d2f1f Compare September 11, 2025 17:26
@codecov

codecov Bot commented Sep 11, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 62.50000% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 61.0%. Comparing base (64ef567) to head (d890309).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
labgrid/util/agents/sysfsgpio.py 70.0% 3 Missing ⚠️
labgrid/driver/gpiodriver.py 0.0% 2 Missing ⚠️
labgrid/remote/exporter.py 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1730   +/-   ##
======================================
  Coverage    61.0%   61.0%           
======================================
  Files         182     182           
  Lines       14867   14874    +7     
======================================
+ Hits         9077    9083    +6     
- Misses       5790    5791    +1     
Flag Coverage Δ
3.10 61.0% <62.5%> (+<0.1%) ⬆️
3.11 61.0% <62.5%> (+<0.1%) ⬆️
3.12 61.0% <62.5%> (+<0.1%) ⬆️
3.13 61.0% <62.5%> (+<0.1%) ⬆️
3.14 61.0% <62.5%> (+<0.1%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Emantor
Emantor previously approved these changes May 30, 2026
pmelange added 3 commits July 8, 2026 10:42
The sysfsgpio resources (SysfsGPIO, NetworkSysfsGPIO and MatchedSysfsGPIO),
the GPIOSysFSExport, the driver GpioDigitalOutputDriver and the
GpioDigitalOutput agent have been modified to have an additional optional
invert (active-low) attribute (default False) which can be used to
invert the logical value used on the gpio line.

Signed-off-by: Perry Melange <isprotejesvalkata@gmail.com>
… for SysfsGPIO

Update the SysfsGPIO, MatchedSysfsGPIO to add the new invert (active-low)
attribute.

Signed-off-by: Perry Melange <isprotejesvalkata@gmail.com>
Add the new invert (active-low) attribute to the examples and add calls
to the new invert method

Signed-off-by: Perry Melange <isprotejesvalkata@gmail.com>

@Bastian-Krause Bastian-Krause left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebased and fixed a typo in the docs.

@Bastian-Krause
Bastian-Krause merged commit 97e7cea into labgrid-project:master Jul 8, 2026
11 checks passed
@pmelange

Copy link
Copy Markdown
Contributor Author

Thank you

@pmelange
pmelange deleted the 25.0.1-sysfsgpio_active_low branch July 13, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants