driver/rawnetworkinterfacedriver: raise when tcpdump fails to start listening#1924
Merged
Bastian-Krause merged 1 commit intoJul 6, 2026
Conversation
…istening If tcpdump exits cleanly without emitting "tcpdump: listening on" (possibly due to the message being changed), readline() is called on a closed stderr stream, resulting in confusing exceptions. Fix that by raising a proper exception in that case. Signed-off-by: Bastian Krause <bst@pengutronix.de>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1924 +/- ##
========================================
- Coverage 61.0% 61.0% -0.1%
========================================
Files 182 182
Lines 14848 14849 +1
========================================
Hits 9067 9067
- Misses 5781 5782 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Emantor
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If tcpdump exits cleanly without emitting "tcpdump: listening on" (possibly due to the message being changed),
readline()is called on a closed stderr stream, resulting in confusing exceptions. Fix that by raising a proper exception in that case.Checklist