remote: exporter: The 'changed' variable is not set when exception oc… #236
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started my exporter on a machine that doesn't have ser2net installed an was prompted with two exceptions. One for the missing ser2net and another one because 'changed' was not assigned.
UnboundLocalError: local variable 'changed' referenced before assignment
I figured we can either continue to the next iteration upon exception, or enclose the 'if changed' conditional into an else clause.. Since we don't do anything but checking for changes, I chose to add a 'continue'.
Signed-off-by: Robin van der Gracht robin@protonic.nl