Skip to content

Conversation

@rvdgracht
Copy link
Contributor

I started my exporter on a machine that doesn't have ser2net installed an was prompted with two exceptions. One for the missing ser2net and another one because 'changed' was not assigned.

UnboundLocalError: local variable 'changed' referenced before assignment

I figured we can either continue to the next iteration upon exception, or enclose the 'if changed' conditional into an else clause.. Since we don't do anything but checking for changes, I chose to add a 'continue'.

Signed-off-by: Robin van der Gracht robin@protonic.nl

…curs

Signed-off-by: Robin van der Gracht <robin@protonic.nl>
@codecov-io
Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #236 into master will decrease coverage by <.1%.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #236     +/-   ##
========================================
- Coverage    55.1%   55.1%   -0.1%     
========================================
  Files         105     105             
  Lines        6218    6219      +1     
========================================
  Hits         3431    3431             
- Misses       2787    2788      +1
Impacted Files Coverage Δ
labgrid/remote/exporter.py 36.2% <0%> (-0.2%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebbe909...1a3e8a9. Read the comment docs.

@Emantor Emantor requested a review from jluebbe April 30, 2018 10:18
@rohieb rohieb mentioned this pull request May 23, 2018
@Emantor
Copy link
Member

Emantor commented May 23, 2018

@jluebbe included a similar fix in #245, closing this.

@Emantor Emantor closed this May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants